Skip to content

fix: RBR Hold Message #63129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 4 commits into from
Jun 4, 2025
+2 −2
Merged

fix: RBR Hold Message #63129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
943cebe
fix: RBR Hold Message
nkdengineer May 30, 2025
1adcd61
Merge branch 'main' into fix/63012 # Please enter a commit
nkdengineer Jun 4, 2025
b88411a
fix translation
nkdengineer Jun 4, 2025
e45e83f
Update src/languages/en.ts
nkdengineer Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5875,7 +5875,7 @@ const translations = {
keepThisOne: 'Keep this one',
confirmDetails: `Confirm the details you're keeping`,
confirmDuplicatesInfo: `The duplicate requests you don't keep will be held for the member to delete`,
hold: 'Hold',
hold: 'This expense was put on hold',
resolvedDuplicates: 'resolved the duplicate',
},
reportViolations: {
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6396,7 +6396,7 @@ const translations = {
keepThisOne: 'Mantener éste',
confirmDetails: 'Confirma los detalles que conservas',
confirmDuplicatesInfo: 'Los duplicados que no conserves se guardarán para que el usuario los elimine',
hold: 'Retenido',
hold: 'Este gasto está retenido',

@hungvu193 hungvu193 May 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you confirm this translation on slack? 👀

@nkdengineer nkdengineer May 30, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App/src/languages/es.ts

Line 1156 in 733010e

expenseOnHold: 'Este gasto está retenido. Revisa los comentarios para saber como proceder.',

App/src/languages/en.ts

Line 1159 in 733010e

expenseOnHold: 'This expense was put on hold. Please review the comments for next steps.',

We have exist translation in here

@hungvu193 hungvu193 May 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but it looks slightly different, right? We need This expense is on hold, but we had This expense was put on hold. I'm not sure about the past tense in Spanish 😂

@nkdengineer nkdengineer Jun 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hungvu193 Should we use This expense was put on hold to make this consistent with other places?

@hungvu193 hungvu193 Jun 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bfitzexpensify on the comment above

@bfitzexpensify bfitzexpensify Jun 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's keep it consistent

@hungvu193 hungvu193 Jun 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming 🙏

@hungvu193 hungvu193 Jun 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkdengineer could you update the english translation?

@hungvu193 hungvu193 Jun 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little bump @nkdengineer

@nkdengineer nkdengineer Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hungvu193 i updated

resolvedDuplicates: 'resolvió el duplicado',
},
reportViolations: {
Expand Down