Skip to content

The radio button is not selected the first time the "Request early cancellation" page is opened #63175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 2 commits into from
Jun 2, 2025
Merged

The radio button is not selected the first time the "Request early cancellation" page is opened #63175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2cfac6
fix: radio button is not selected after reload page
thelullabyy May 30, 2025
8725ded
fix lint
thelullabyy May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/components/Form/FormProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {useOnyx} from 'react-native-onyx';
import {useInputBlurContext} from '@components/InputBlurContext';
import useDebounceNonReactive from '@hooks/useDebounceNonReactive';
import useLocalize from '@hooks/useLocalize';
import usePrevious from '@hooks/usePrevious';
import {isSafari} from '@libs/Browser';
import {prepareValues} from '@libs/ValidationUtils';
import Visibility from '@libs/Visibility';
Expand All @@ -18,6 +19,7 @@ import ONYXKEYS from '@src/ONYXKEYS';
import type {Form} from '@src/types/form';
import type {Errors} from '@src/types/onyx/OnyxCommon';
import {isEmptyObject} from '@src/types/utils/EmptyObject';
import isLoadingOnyxValue from '@src/types/utils/isLoadingOnyxValue';
import KeyboardUtils from '@src/utils/keyboard';
import type {RegisterInput} from './FormContext';
import FormContext from './FormContext';
Expand Down Expand Up @@ -111,11 +113,20 @@ function FormProvider(
) {
const [network] = useOnyx(ONYXKEYS.NETWORK, {canBeMissing: true});
const [formState] = useOnyx<OnyxFormKey, Form>(`${formID}`, {canBeMissing: true});
const [draftValues] = useOnyx<OnyxFormDraftKey, Form>(`${formID}Draft`, {canBeMissing: true});
const [draftValues, draftValuesMetadata] = useOnyx<OnyxFormDraftKey, Form>(`${formID}Draft`, {canBeMissing: true});
const {preferredLocale, translate} = useLocalize();
const inputRefs = useRef<InputRefs>({});
const touchedInputs = useRef<Record<string, boolean>>({});
const [inputValues, setInputValues] = useState<Form>(() => ({...draftValues}));
const isLoadingDraftValues = isLoadingOnyxValue(draftValuesMetadata);
const prevIsLoadingDraftValues = usePrevious(isLoadingDraftValues);

useEffect(() => {
if (isLoadingDraftValues || !prevIsLoadingDraftValues) {
return;
}
setInputValues({...draftValues});
}, [isLoadingDraftValues, draftValues, prevIsLoadingDraftValues]);
const [errors, setErrors] = useState<GenericFormInputErrors>({});
const hasServerError = useMemo(() => !!formState && !isEmptyObject(formState?.errors), [formState]);
const {setIsBlurred} = useInputBlurContext();
Expand Down