Skip to content

[CP Staging] [NoQA] Enable table report view for everyone #63255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 2 commits into from
Jun 2, 2025
Merged

[CP Staging] [NoQA] Enable table report view for everyone #63255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc6e23c
Hardcode return value for the table reprot views
mountiny Jun 2, 2025
c4c831b
Remove redundant tests
mountiny Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libs/Permissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,11 @@ function canUseCustomRules(betas: OnyxEntry<Beta[]>): boolean {
return !!betas?.includes(CONST.BETAS.CUSTOM_RULES) || canUseAllBetas(betas);
}

/**
* The feature is released so hardcoding the value to true while we clean up the beta from the code.
*/
function canUseTableReportView(betas: OnyxEntry<Beta[]>): boolean {
return !!betas?.includes(CONST.BETAS.TABLE_REPORT_VIEW) || canUseAllBetas(betas);
return true || !!betas?.includes(CONST.BETAS.TABLE_REPORT_VIEW) || canUseAllBetas(betas);
Comment thread
mountiny marked this conversation as resolved.
}

function canUseTalkToAISales(betas: OnyxEntry<Beta[]>): boolean {
Expand Down
37 changes: 0 additions & 37 deletions tests/actions/IOUTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,26 +1589,6 @@ describe('actions/IOU', () => {
});
expect(notifyNewAction).toHaveBeenCalledTimes(1);
});

it('trigger notifyNewAction when doing the money request without canUseTableReportView permission', () => {
requestMoney({
report: {reportID: '123', type: CONST.REPORT.TYPE.EXPENSE},
participantParams: {
payeeEmail: RORY_EMAIL,
payeeAccountID: RORY_ACCOUNT_ID,
participant: {login: CARLOS_EMAIL, accountID: CARLOS_ACCOUNT_ID},
},
transactionParams: {
amount: 1,
attendees: [],
currency: CONST.CURRENCY.USD,
created: '',
merchant: '',
comment: '',
},
});
expect(notifyNewAction).toHaveBeenCalledTimes(1);
});
});

describe('createDistanceRequest', () => {
Expand Down Expand Up @@ -1647,23 +1627,6 @@ describe('actions/IOU', () => {
});
expect(notifyNewAction).toHaveBeenCalledTimes(1);
});

it('trigger notifyNewAction when doing the money request without canUseTableReportView permission', () => {
createDistanceRequest({
report: {reportID: '123', type: CONST.REPORT.TYPE.EXPENSE},
participants: [],
transactionParams: {
amount: 1,
attendees: [],
currency: CONST.CURRENCY.USD,
created: '',
merchant: '',
comment: '',
validWaypoints: {},
},
});
expect(notifyNewAction).toHaveBeenCalledTimes(1);
});
});

describe('split expense', () => {
Expand Down