Update react-native-key-command to fix escape shortcuts override each other#63374
Conversation
|
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2025-06-03.at.5.46.09.PM.movMacOS: Desktop |
|
Looks like the reassure test is failing for some reason. |
|
Merging in spite of the test failure because the failure is unrelated to this PR and this is a deploy blocking bug. Discussed here: https://expensify.slack.com/archives/C01GTK53T8Q/p1748970781030629?thread_ts=1748910780.767669&cid=C01GTK53T8Q |
…all-as-read Update react-native-key-command to fix escape shortcuts override each other (cherry picked from commit e4f4c9a) (cherry-picked to staging by roryabraham)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.1.56-9 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.1.58-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.58-4 🚀
|
Explanation of Change
Fixed Issues
$ #63278
$ #61622
PROPOSAL: #61622 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
A.
B.
Can't use shortcut in native and Android mWeb
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4