Skip to content

[No QA] Bump PATCH version after prod CPs #63383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 1 commit into from
Jun 3, 2025
Merged

[No QA] Bump PATCH version after prod CPs #63383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/cherryPick.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,14 @@ jobs:
uses: ./.github/workflows/createNewVersion.yml
secrets: inherit
with:
# In order to submit a new build for production review, it must have a higher PATCH version than the previously-submitted build
SEMVER_LEVEL: ${{ inputs.TARGET == 'staging' && 'BUILD' || 'PATCH' }}
# In order to submit a new build for production review, it must have a higher PATCH version than the previously-submitted build.
# The typical case is that with each staging deploy, we bump the BUILD version, and with each prod deploy we bump the PATCH version.
# However, if PULL_REQUEST_URL is empty, we assume we want to do a PATCH version bump.
# The reason we assume that is because the use-case for a no-PR CP is after a CP to Production.
# In that case, we need to bump the staging version to be higher than prod.
# We use a patch version so that there's a diff in both `CFBundleVersion` and `CFBundleShortVersion` on iOS,
# so that when we later CP that version bump to staging, the `CFBundleShortVersion` diff is picked up as well.
SEMVER_LEVEL: ${{ (inputs.TARGET == 'production' || inputs.PULL_REQUEST_URL == '') && 'PATCH' || 'BUILD' }}

cherryPick:
needs: createNewVersion
Expand Down
Loading