Skip to content

Add empty state to reports view #63440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 4 commits into from
Jun 5, 2025
+24 −14
Merged

Add empty state to reports view #63440

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6be8fcb
update empty search view
JS00001 Jun 4, 2025
38f67b4
update empty state
JS00001 Jun 5, 2025
3e17c59
Merge branch 'main' of github.com:Expensify/App into jsenyitko-report…
JS00001 Jun 5, 2025
bdf7d90
fix eslint
JS00001 Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions src/pages/Search/EmptySearchView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,16 @@ function EmptySearchView({hash, type, groupBy, hasResults}: EmptySearchViewProps
const viewTourReportID = introSelected?.viewTour;
const [viewTourReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${viewTourReportID}`, {canBeMissing: true});

// Default 'Folder' lottie animation, along with its background styles
const defaultViewItemHeader = useMemo(
() => ({
headerMedia: LottieAnimations.GenericEmptyState,
headerContentStyles: [styles.emptyStateFolderWebStyles, StyleUtils.getBackgroundColorStyle(theme.emptyFolderBG)],
lottieWebViewStyles: {backgroundColor: theme.emptyFolderBG, ...styles.emptyStateFolderWebStyles},
}),
[StyleUtils, styles.emptyStateFolderWebStyles, theme.emptyFolderBG],
);

const content: EmptySearchViewItem = useMemo(() => {
// Begin by going through all of our To-do searches, and returning their empty state
// if it exists
Expand Down Expand Up @@ -202,12 +212,18 @@ function EmptySearchView({hash, type, groupBy, hasResults}: EmptySearchViewProps

// If we are grouping by reports, show a custom message rather than a type-specific message
if (groupBy === CONST.SEARCH.GROUP_BY.REPORTS) {
if (hasResults) {
return {
...defaultViewItemHeader,
title: translate('search.searchResults.emptyResults.title'),
subtitle: translate('search.searchResults.emptyResults.subtitle'),
Comment thread
JS00001 marked this conversation as resolved.
};
}

return {
headerMedia: LottieAnimations.GenericEmptyState,
...defaultViewItemHeader,
title: translate('search.searchResults.emptyReportResults.title'),
subtitle: translate(hasSeenTour ? 'search.searchResults.emptyReportResults.subtitleWithOnlyCreateButton' : 'search.searchResults.emptyReportResults.subtitle'),
headerContentStyles: [styles.emptyStateFolderWebStyles, StyleUtils.getBackgroundColorStyle(theme.emptyFolderBG)],
lottieWebViewStyles: {backgroundColor: theme.emptyFolderBG, ...styles.emptyStateFolderWebStyles},
buttons: [
...(!hasSeenTour
? [
Expand Down Expand Up @@ -272,7 +288,7 @@ function EmptySearchView({hash, type, groupBy, hasResults}: EmptySearchViewProps
case CONST.SEARCH.DATA_TYPES.EXPENSE:
if (!hasResults) {
return {
headerMedia: LottieAnimations.GenericEmptyState,
...defaultViewItemHeader,
title: translate('search.searchResults.emptyExpenseResults.title'),
subtitle: translate(hasSeenTour ? 'search.searchResults.emptyExpenseResults.subtitleWithOnlyCreateButton' : 'search.searchResults.emptyExpenseResults.subtitle'),
buttons: [
Expand All @@ -297,16 +313,13 @@ function EmptySearchView({hash, type, groupBy, hasResults}: EmptySearchViewProps
success: true,
},
],
headerContentStyles: [styles.emptyStateFolderWebStyles, StyleUtils.getBackgroundColorStyle(theme.emptyFolderBG)],
lottieWebViewStyles: {backgroundColor: theme.emptyFolderBG, ...styles.emptyStateFolderWebStyles},
};
}
// We want to display the default nothing to show message if there is any filter applied.
// eslint-disable-next-line no-fallthrough
case CONST.SEARCH.DATA_TYPES.INVOICE:
if (!hasResults) {
return {
headerMedia: LottieAnimations.GenericEmptyState,
title: translate('search.searchResults.emptyInvoiceResults.title'),
subtitle: translate(hasSeenTour ? 'search.searchResults.emptyInvoiceResults.subtitleWithOnlyCreateButton' : 'search.searchResults.emptyInvoiceResults.subtitle'),
buttons: [
Expand All @@ -331,19 +344,16 @@ function EmptySearchView({hash, type, groupBy, hasResults}: EmptySearchViewProps
success: true,
},
],
headerContentStyles: [styles.emptyStateFolderWebStyles, StyleUtils.getBackgroundColorStyle(theme.emptyFolderBG)],
lottieWebViewStyles: {backgroundColor: theme.emptyFolderBG, ...styles.emptyStateFolderWebStyles},
...defaultViewItemHeader,
};
}
// eslint-disable-next-line no-fallthrough
case CONST.SEARCH.DATA_TYPES.CHAT:
default:
return {
headerMedia: LottieAnimations.GenericEmptyState,
...defaultViewItemHeader,
title: translate('search.searchResults.emptyResults.title'),
subtitle: translate('search.searchResults.emptyResults.subtitle'),
headerContentStyles: [styles.emptyStateFolderWebStyles, StyleUtils.getBackgroundColorStyle(theme.emptyFolderBG)],
lottieWebViewStyles: {backgroundColor: theme.emptyFolderBG, ...styles.emptyStateFolderWebStyles},
};
}
}, [
Expand All @@ -354,21 +364,21 @@ function EmptySearchView({hash, type, groupBy, hasResults}: EmptySearchViewProps
translate,
StyleUtils,
theme.todoBG,
theme.emptyFolderBG,
theme.travelBG,
styles.emptyStateFireworksWebStyles,
styles.emptyStateFolderWebStyles,
styles.textAlignLeft,
styles.tripEmptyStateLottieWebView,
introSelected?.choice,
hasResults,
defaultViewItemHeader,
hasSeenTour,
isBetaEnabled,
groupPoliciesWithChatEnabled,
activePolicy,
activePolicyID,
currentUserPersonalDetails,
tripViewChildren,
hasResults,
shouldRedirectToExpensifyClassic,
viewTourReport,
viewTourReportID,
Expand Down
Loading