Stop highlighting old transaction, when cache was cleared by SzymczakJ · Pull Request #64073 · Expensify/App

SzymczakJ · 2025-06-12T13:33:32Z

Explanation of Change

This PR adds useNewTransactions hook that computes new transaction in the table report view(this logic was implemented before in MoneyRequestReportView and ReportScreen) and adds logic to skip first computation of new transactions on first report load. We do that to avoid the highlighting of reports that were present in the report, but weren't saved to onyx(becasue, for example cache was cleared).

Fixed Issues

$ #63734
PROPOSAL:

Tests

Log out and log in.
Enter a report from Reports page and make sure that transactions that were already in this report are not highlighted.
Enter another report(best if it's in another workspace/DM) from Inbox and make sure that transactions that were already in this report are not highlighted.
Try adding expenses to these Reports and make sure they are highlighted.

Offline tests

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-06-16.at.13.50.07.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-06-16.at.13.45.44.mov

MacOS: Desktop

Kicu

Looks decent, taking into the account problems with other solutions.

It is not idea to base this solution on time passed since initial render, though I understand why you did it.

I think if we stay with this solution, you should write (here on github) a few lines describing why it is difficult in onyx to differentiate between first and subsequent loadings of transactions.
Such a description would allow for other developers to get involved and possibly help.

Kicu · 2025-06-13T08:25:07Z

    const {reportActions: unfilteredReportActions, hasNewerActions, hasOlderActions} = usePaginatedReportActions(reportID);
    const reportActions = getFilteredReportActionsForReportView(unfilteredReportActions);

+    // ref used to not compute new transaction on the first full load to avoid highlighting transactions that belonged to the report but weren't present in Onyx


rephrase ref used to not compute (...)

…-when-cache-was-cleared

melvin-bot · 2025-06-16T11:15:51Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-06-17T06:30:54Z

 function selectAllTransactionsForReport(transactions: OnyxCollection<Transaction>, reportID: string | undefined, reportActions: ReportAction[]) {
    if (!reportID) {
-        return [];
+        return undefined;


Is there any reason why we need to return undefined here?

If the transaction is empty array we also return empty string in useNewTransactions

I was experimenting with it as a way to indicate loading state and forgot to roll it back. It's done now.

DylanDylann · 2025-06-17T06:40:35Z

@SzymczakJ The others looks fine

… selector

DylanDylann · 2025-06-17T08:24:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-17.at.15.22.07.mov

Android: mWeb Chrome

Screen.Recording.2025-06-17.at.15.21.02.mov

iOS: HybridApp

Screen.Recording.2025-06-17.at.15.19.56.mov

iOS: mWeb Safari

Screen.Recording.2025-06-17.at.15.18.35.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-17.at.14.52.05.mov

MacOS: Desktop

Screen.Recording.2025-06-17.at.14.58.20.mov

DylanDylann

LGTM

mountiny

Thank you

mountiny · 2025-06-18T21:25:13Z

@SzymczakJ on Monday, can you please add tests for the hook? I feel like we should capture its logic with tests but dont want to hold the PR for it as you are ooo the rest of the week. Thanks!

OSBotify · 2025-06-18T21:34:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-18T23:45:07Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.69-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-19T09:39:34Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.69-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-19T10:19:49Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.69-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-20T12:47:13Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.69-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

trjExpensify · 2025-06-30T12:27:08Z

@SzymczakJ did you add these tests? #64073 (comment)

SzymczakJ · 2025-06-30T14:57:55Z

Here's an open PR for it #64938 approved)

trjExpensify · 2025-06-30T18:12:26Z

Excellent, thanks!

SzymczakJ added 2 commits June 12, 2025 15:16

stop highlighting old transaction, when cache was cleared

3188cc9

add hasOnceLoadedReportActions condition to init firstFullLoadTime ref

ba3cab3

Kicu reviewed Jun 13, 2025

View reviewed changes

SzymczakJ added 6 commits June 13, 2025 16:21

refactor new transaction highlightitng logic

eb85de7

clean up transaction highlighting logic and add explanation comments

889634f

remove unused code

27f66a1

fix PR comments

82f7bd3

Merge branch 'main' into @szymczak/stop-highlighting-old-transactions…

766e36b

…-when-cache-was-cleared

fix typescript

f5c10f4

SzymczakJ marked this pull request as ready for review June 16, 2025 11:15

SzymczakJ requested a review from a team as a code owner June 16, 2025 11:15

melvin-bot Bot requested review from DylanDylann and removed request for a team June 16, 2025 11:15

DylanDylann reviewed Jun 17, 2025

View reviewed changes

come back to returning empty arrray in selectAllTransactionsForReport…

70e7594

… selector

DylanDylann approved these changes Jun 17, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny June 17, 2025 08:25

mountiny assigned SzymczakJ Jun 17, 2025

mountiny approved these changes Jun 18, 2025

View reviewed changes

mountiny merged commit b2eddc7 into Expensify:main Jun 18, 2025
18 of 19 checks passed

github-actions Bot mentioned this pull request Jun 18, 2025

Deploy Checklist: New Expensify 2025-06-18 #64518

Closed

58 tasks

melvin-bot Bot mentioned this pull request Jun 20, 2025

[Due for payment 2025-06-27] [Better Expense Report View] Stop highlighting old transaction, when cache was cleared #63734

Closed

Conversation

SzymczakJ commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Kicu left a comment

Choose a reason for hiding this comment

Uh oh!

Kicu Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 16, 2025

Uh oh!

DylanDylann Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

SzymczakJ Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jun 17, 2025

Uh oh!

DylanDylann commented Jun 17, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jun 18, 2025

Uh oh!

Uh oh!

OSBotify commented Jun 18, 2025

Uh oh!

github-actions Bot commented Jun 18, 2025

Uh oh!

github-actions Bot commented Jun 19, 2025

Uh oh!

github-actions Bot commented Jun 19, 2025

Uh oh!

github-actions Bot commented Jun 20, 2025

Uh oh!

trjExpensify commented Jun 30, 2025

Uh oh!

SzymczakJ commented Jun 30, 2025

Uh oh!

trjExpensify commented Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SzymczakJ commented Jun 12, 2025 •

edited

Loading