Skip to content

Open report from switcher perf improvement #64077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 9 commits into from
Jul 2, 2025
Merged

Open report from switcher perf improvement #64077

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e0451a1
move onRouterClose
rinej Jun 12, 2025
2c795fb
refactor SearchRouterContext
rinej Jun 12, 2025
4ab9cef
Revert "refactor SearchRouterContext"
rinej Jun 16, 2025
276892f
Merge branch 'main' into Open-Report-from-Switcher-perf-improvement
rinej Jun 16, 2025
db711c0
add useCallback to decrease render counts for searchRouterContext
rinej Jun 16, 2025
3a59c8b
Merge branch 'main' into Open-Report-from-Switcher-perf-improvement
rinej Jun 30, 2025
36c4050
adjust SearchRouterContext logic
rinej Jun 30, 2025
20b9737
remove runAfterInteraction
rinej Jun 30, 2025
000ee76
Merge branch 'main' into Open-Report-from-Switcher-perf-improvement
rinej Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Search/SearchRouter/SearchRouter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,13 +375,13 @@ function SearchRouter({onRouterClose, shouldHideInputCaret, isSearchRouterDispla
}
} else {
backHistory(() => {
onRouterClose();
if (item?.reportID) {
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(item.reportID));
} else if ('login' in item) {
navigateToAndOpenReport(item.login ? [item.login] : [], false);
}
});
onRouterClose();

const endTime = Date.now();
Log.info('[CMD_K_DEBUG] Navigation item handled', false, {
Expand Down
Loading