refactor split phrase hasCurrencyError by PiyushChandra17 · Pull Request #64148 · Expensify/App

PiyushChandra17 · 2025-06-13T07:32:53Z

Explanation of Change

refactor

Fixed Issues

$ #62808
PROPOSAL: #62808 (Comment)

Tests

Pre-condition: set default currency to not USD

Open the New Expensify mobile app
Tap on Workspaces tab
Tap on that workspace
Go to workflow
Go to Connect bank account
Verify the error text sentence "Oops! It appears that your workspace currency is set to a different currency than USD..." text is displayed correctly and we are able to click the link and being redirected

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…andra17/refactor/splitphrase/hasCurrencyError

melvin-bot · 2025-06-13T07:32:59Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…se/hasCurrencyError

https://github.com/PiyushChandra17/App into PiyushChandra17/refactor/splitphrase/hasCurrencyError

PiyushChandra17 · 2025-06-14T11:52:38Z

@allgandalf this type check error is because we have added new languages

allgandalf · 2025-06-17T13:04:42Z

@PiyushChandra17 lets fix type errors, we now require translations in all languages , please update all the related files

…se/hasCurrencyError

allgandalf · 2025-06-18T12:00:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allgandalf · 2025-06-18T12:49:39Z

-                    {translate('bankAccount.hasCurrencyError.link')}
-                </TextLink>
-                {translate('bankAccount.hasCurrencyError.phrase2')}
+                {getPlatform() === CONST.PLATFORM.IOS || getPlatform() === CONST.PLATFORM.ANDROID || getPlatform() === CONST.PLATFORM.DESKTOP ? (


I do not understand the need to have this platform specific, also why are we using TextLink? there is not need to use here no?

@allgandalf I think there were parsing URL error on web via TextLink thats why i have used it, if removing that TextLink resolves the problem then i'll fix it

@allgandalf How will we handle onPress then ?

Check this change for reference:

https://github.com/Expensify/App/pull/63900/files#diff-006df38d584b9b8d5ca2d29fad3b5af591e038d142ffa76188bf05cf7185b154R36

allgandalf · 2025-06-18T12:50:05Z

-            phrase2: ' to set it to USD and try again.',
-        },
+        hasCurrencyError:
+            'Oops! It appears that your workspace currency is set to a different currency than USD. To proceed, please go to <a>your workspace settings</a> to set it to USD and try again.',


Why is there no link added in the anchor tag?

@allgandalf Can we use environmentURL here?

…se/hasCurrencyError

PiyushChandra17 · 2025-06-19T06:21:27Z

@allgandalf Can you review this PR, i think we need to handle isSmallScreenWidth and navigate to route accordingly initial or overview.

I tried to play around like this

    const workspaceInitialRoute = `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(policyIDParam, Navigation.getActiveRoute())}`;

    const workspaceOverviewRoute = `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(policyIDParam, Navigation.getActiveRoute())}`;

const routeToNavigate = isSmallScreenWidth ? workspaceOverviewRoute :  workspaceInitialRoute

   <RenderHTML html={translate('bankAccount.hasCurrencyError', {routeToNavigate})} />

However this doesn't seem to work, can you run this on local branch and verify.

…encyError

…se/hasCurrencyError

PiyushChandra17 · 2025-06-20T18:25:04Z

@allgandalf This PR is ready for review

trjExpensify · 2025-06-24T11:22:47Z

👋 @PiyushChandra17 you have conflicts on this one, can you resolve please? Thanks!

…encyError

PiyushChandra17 · 2025-06-24T17:08:20Z

@trjExpensify Done

allgandalf · 2025-06-25T03:40:34Z

@PiyushChandra17 conflicts still exist

…encyError

…se/hasCurrencyError

PiyushChandra17 · 2025-06-25T08:49:21Z

@allgandalf Conflicts fixed

allgandalf · 2025-06-25T17:59:20Z

There are conflicts !

…encyError

…se/hasCurrencyError

PiyushChandra17 · 2025-06-26T05:36:17Z

@allgandalf Conflicts resolved

allgandalf · 2025-06-26T19:07:13Z

    },
    "node_modules/core-util-is": {
      "version": "1.0.2",
-      "dev": true,


please don't update this file

@allgandalf i think I did npm install, will remove that change

…se/hasCurrencyError

PiyushChandra17 · 2025-06-26T20:14:01Z

@allgandalf Done

roryabraham · 2025-06-30T21:03:32Z

sorry, we have conflicts here

…encyError

PiyushChandra17 · 2025-07-01T05:18:50Z

@roryabraham Conflicts resolved

PiyushChandra17 · 2025-07-01T18:38:32Z

@roryabraham gentle bump

OSBotify · 2025-07-03T14:42:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-03T19:44:55Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

github-actions · 2025-07-07T10:56:34Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.76-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

PiyushChandra17 added 2 commits June 13, 2025 11:09

refactor split phrase hasCurrencyError

db419f4

Merge branch 'main' of https://github.com/Expensify/App into PiyushCh…

97aa1ac

…andra17/refactor/splitphrase/hasCurrencyError

PiyushChandra17 requested a review from a team as a code owner June 13, 2025 07:32

melvin-bot Bot requested a review from allgandalf June 13, 2025 07:32

melvin-bot Bot removed the request for review from a team June 13, 2025 07:32

Merge branch 'Expensify:main' into PiyushChandra17/refactor/splitphra…

87e815b

…se/hasCurrencyError

roryabraham self-requested a review June 13, 2025 20:28

PiyushChandra17 mentioned this pull request Jun 13, 2025

Stop splitting up phrases for formatting #62808

Closed

PiyushChandra17 and others added 4 commits June 14, 2025 16:03

added RenderHTML

1816184

Merge branch 'Expensify:main' into PiyushChandra17/refactor/splitphra…

7ffe1db

…se/hasCurrencyError

Merge branch 'PiyushChandra17/refactor/splitphrase/hasCurrencyError' of

ab2f21f

https://github.com/PiyushChandra17/App into PiyushChandra17/refactor/splitphrase/hasCurrencyError

Fix parsing url

1d82d0a

PiyushChandra17 and others added 2 commits June 18, 2025 13:44

Merge branch 'Expensify:main' into PiyushChandra17/refactor/splitphra…

4c5ad03

…se/hasCurrencyError

updated translations in all languages

2cf7918

allgandalf suggested changes Jun 18, 2025

View reviewed changes

PiyushChandra17 and others added 2 commits June 19, 2025 09:50

Merge branch 'Expensify:main' into PiyushChandra17/refactor/splitphra…

fb843a5

…se/hasCurrencyError

added workspaceInitialRoute

c8d1f6f

PiyushChandra17 and others added 6 commits June 19, 2025 16:29

updated translations in all languages

1680f27

Merge branch 'main' into PiyushChandra17/refactor/splitphrase/hasCurr…

a0f2e8e

…encyError

added workspaceRoute

83f2106

added the check hasUnsupportedCurrency

3d98b86

Merge branch 'Expensify:main' into PiyushChandra17/refactor/splitphra…

ee8dd3f

…se/hasCurrencyError

hasCurrencyError splitphrase up-to-date

01850ff

Merge branch 'main' into PiyushChandra17/refactor/splitphrase/hasCurr…

524589e

…encyError

PiyushChandra17 added 2 commits June 25, 2025 10:57

Merge branch 'main' into PiyushChandra17/refactor/splitphrase/hasCurr…

7aafcb5

…encyError

Merge branch 'Expensify:main' into PiyushChandra17/refactor/splitphra…

67cd724

…se/hasCurrencyError

PiyushChandra17 and others added 4 commits June 26, 2025 00:32

Merge branch 'main' into PiyushChandra17/refactor/splitphrase/hasCurr…

76d2d99

…encyError

Merge branch 'Expensify:main' into PiyushChandra17/refactor/splitphra…

71599bb

…se/hasCurrencyError

Fix prettier

ceae223

removed TextLink

bf36189

allgandalf suggested changes Jun 26, 2025

View reviewed changes

PiyushChandra17 and others added 3 commits June 27, 2025 01:06

remove changes from package-lock.json

679c790

removed changes from package-lock.json

753352b

Merge branch 'Expensify:main' into PiyushChandra17/refactor/splitphra…

e71d793

…se/hasCurrencyError

allgandalf approved these changes Jun 27, 2025

View reviewed changes

PiyushChandra17 and others added 2 commits July 1, 2025 09:41

Merge branch 'main' into PiyushChandra17/refactor/splitphrase/hasCurr…

7a3b763

…encyError

Fix merge conflicts

3da194c

roryabraham approved these changes Jul 3, 2025

View reviewed changes

roryabraham merged commit c5d9bf0 into Expensify:main Jul 3, 2025
18 checks passed

github-actions Bot mentioned this pull request Jul 3, 2025

Deploy Checklist: New Expensify 2025-07-03 #65447

Closed

63 tasks

PiyushChandra17 mentioned this pull request Jul 14, 2025

[Due for payment 2025-07-25] [$250] Android - Expense - Connect bank account page is cut off #66016

Closed

8 tasks

Conversation

PiyushChandra17 commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 13, 2025

Uh oh!

PiyushChandra17 commented Jun 14, 2025

Uh oh!

allgandalf commented Jun 17, 2025

Uh oh!

allgandalf commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

PiyushChandra17 Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

PiyushChandra17 Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

PiyushChandra17 Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PiyushChandra17 commented Jun 19, 2025

Uh oh!

PiyushChandra17 commented Jun 20, 2025

Uh oh!

trjExpensify commented Jun 24, 2025

Uh oh!

PiyushChandra17 commented Jun 24, 2025

Uh oh!

allgandalf commented Jun 25, 2025

Uh oh!

PiyushChandra17 commented Jun 25, 2025

Uh oh!

allgandalf commented Jun 25, 2025

Uh oh!

PiyushChandra17 commented Jun 26, 2025

Uh oh!

allgandalf Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

PiyushChandra17 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

PiyushChandra17 commented Jun 26, 2025

Uh oh!

roryabraham commented Jun 30, 2025

Uh oh!

PiyushChandra17 commented Jul 1, 2025

Uh oh!

PiyushChandra17 commented Jul 1, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 3, 2025

Uh oh!

github-actions Bot commented Jul 3, 2025

Uh oh!

github-actions Bot commented Jul 7, 2025

Uh oh!

Reviewers

Assignees

PiyushChandra17 commented Jun 13, 2025 •

edited

Loading

allgandalf commented Jun 18, 2025 •

edited

Loading

PiyushChandra17 Jun 18, 2025 •

edited

Loading