Fix freezing app #64651
Merged
Merged
Conversation
…ibutes The persistent array was creating circular dependencies by reprocessing previously updated reports during transaction updates.
Contributor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
…to fix-freezing-app-v1
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
…to fix-freezing-app-v1
…to fix-freezing-app-v1
kubabutkiewicz
commented
Jun 25, 2025
melvin-bot
Bot
requested review from
abdulrahuman5196
and removed request for
a team
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mountiny
requested review from
ZhenjaHorbach
and removed request for
abdulrahuman5196
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-06-25.23.46.44.movAndroid: mWeb Chrome2025-06-25.23.04.59.moviOS: HybridAppUploading Запись экрана 2025-06-25 в 22.59.22.mov… iOS: mWeb Safari2025-06-25.22.59.22.movMacOS: Chrome / Safari2025-06-25.22.57.57.movMacOS: Desktop2025-06-25.22.57.57.mov |
| .map((reportKey) => reports?.[reportKey]?.chatReportID) | ||
| .filter(Boolean) | ||
| .map((chatReportID) => `${ONYXKEYS.COLLECTION.REPORT}${chatReportID}`); | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe we could simplify this a little bit without intermediate arrays?
const {violationReportIDs, chatReportIDs} = Object
.keys(transactionViolationsUpdates)
.reduce((acc, key) => {
const txId = key.replace(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, '');
const reportID = transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${txId}`]?.reportID;
if (!reportID) {
return acc;
}
const reportKey = `${ONYXKEYS.COLLECTION.REPORT}${reportID}`;
acc.violationReportIDs.push(reportKey);
const chatID = reports?.[reportKey]?.chatReportID;
if (chatID) {
acc.chatReportIDs.push(`${ONYXKEYS.COLLECTION.REPORT}${chatID}`);
}
return acc;
}, {violationReportIDs: [], chatReportIDs: []});
transactionReportIDs = [
...transactionReportIDs,
...violationReportIDs,
...chatReportIDs,
];
Contributor
|
Interesting thing on adhoc build Although after the adhoc build there were additional commits 
|
Contributor
|
@mountiny But if we want we can merge it now ! |
Contributor
Author
|
@ZhenjaHorbach yes, this was a bug earlier which I noticed and the latter changes should fix it. |
mountiny
approved these changes
Jun 27, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀
|
8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The persistent array was creating circular dependencies by reprocessing previously updated reports during transaction updates.
Explanation of Change
Fixed Issues
$ #64754
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop