Skip to content

Reports Page - Open reports show receiver in narrow screen #64883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Jul 5, 2025
Merged

Reports Page - Open reports show receiver in narrow screen #64883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c201f4e
fix: Open reports show receiver in narrow screen
thelullabyy Jun 25, 2025
9fc0494
fix: unit test
thelullabyy Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libs/SearchUIUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
];

let currentAccountID: number | undefined;
Onyx.connect({

Check warning on line 155 in src/libs/SearchUIUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.SESSION,
callback: (session) => {
currentAccountID = session?.accountID;
Expand Down Expand Up @@ -910,12 +910,13 @@
const isIOUReport = reportItem.type === CONST.REPORT.TYPE.IOU;

const reportPendingAction = reportItem?.pendingAction ?? reportItem?.pendingFields?.preview;
const shouldShowBlankTo = !reportItem || isOpenExpenseReport(reportItem);

@allgandalf allgandalf Jul 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name here should be shouldShowTo and the condition reciprocated!

@allgandalf allgandalf Jul 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thelullabyy can you please update the name and the associated conditions

@thelullabyy thelullabyy Jul 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allgandalf I think we should keep the current name as it is already used similarly below. What do you think @mountiny

App/src/libs/SearchUIUtils.ts

Line 936 in 7eba98d

const shouldShowBlankTo = !report || isOpenExpenseReport(report);

reportIDToTransactions[reportKey] = {
...reportItem,
action: getAction(data, allViolations, key),
keyForList: reportItem.reportID,
from: data.personalDetailsList?.[reportItem.accountID ?? CONST.DEFAULT_NUMBER_ID],
to: reportItem.managerID ? data.personalDetailsList?.[reportItem.managerID] : emptyPersonalDetails,
to: !shouldShowBlankTo && reportItem.managerID ? data.personalDetailsList?.[reportItem.managerID] : emptyPersonalDetails,
transactions,
...(reportPendingAction ? {pendingAction: reportPendingAction} : {}),
};
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/Search/SearchUIUtilsTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,10 +731,10 @@ const reportsListItems = [
stateNum: 0,
statusNum: 0,
to: {
accountID: 18439984,
avatar: 'https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/avatar_3.png',
displayName: 'Admin',
login: adminEmail,
accountID: 0,
avatar: '',
displayName: undefined,
login: undefined,
},
total: -5000,
transactions: [
Expand Down
Loading