Expense - Workspace chat still displays GBR in LHN after changing report workspace by thelullabyy · Pull Request #64909 · Expensify/App

thelullabyy · 2025-06-25T10:18:31Z

Explanation of Change

Fixed Issues

$#64452
PROPOSAL:#64452 (comment)

Tests

Precondition:

Create a workspace with Admin, Approver and Member.

Go to the app
[Member] Submit an expense in the workspace chat.
[Member] Click Submit on the expense preview.
[Approver] Create a new workspace.
[Approver] Open workspace chat with member.
[Approver] Open the expense report.
[Approver] Click More > Change workspace.
[Approver] Select the new workspace.
[Approver] Open the workspace chat with member from Step 5.
Verify workspace chat is empty and Member's workspace chat in LHN not have GBR

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

Create a workspace with Admin, Approver and Member.

Go to the app
[Member] Submit an expense in the workspace chat.
[Member] Click Submit on the expense preview.
[Approver] Create a new workspace.
[Approver] Open workspace chat with member.
[Approver] Open the expense report.
[Approver] Click More > Change workspace.
[Approver] Select the new workspace.
[Approver] Open the workspace chat with member from Step 5.
Verify workspace chat is empty and Member's workspace chat in LHN not have GBR

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android_chorme.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_safari.mov

MacOS: Chrome / Safari

chorme.mov

MacOS: Desktop

desktop.mov

…orkspace

melvin-bot · 2025-06-25T14:04:23Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2025-06-25T18:58:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-26.at.03.05.00-compressed.mov

Android: mWeb Chrome

Screen.Recording.2025-06-30.at.16.34.43-compressed.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2025-06-26.at.02.51.11-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-26.at.02.15.51-compressed.mov

MacOS: Desktop

Screen.Recording.2025-06-26.at.02.52.35.mov

dominictb

Should follow coding convention even in unit tests.

dominictb · 2025-06-25T19:10:45Z

+
+            await Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${fakeReport.reportID}`, MOCK_REPORT_ACTIONS);
+
+            expect(getIOUReportActionToApproveOrPay(fakeReport, '3')).toMatchObject(MOCK_REPORT_ACTIONS['1']);


Suggested change

expect(getIOUReportActionToApproveOrPay(fakeReport, '3')).toMatchObject(MOCK_REPORT_ACTIONS['1']);

expect(getIOUReportActionToApproveOrPay(fakeReport)).toMatchObject(MOCK_REPORT_ACTIONS['1']);

@dominictb getIOUReportActionToApproveOrPay require 2 arguments

dominictb

Do we actually need the "Approver" in Tests? Test steps should be minimal to reproduce the issue.

thelullabyy · 2025-06-27T02:31:56Z

@dominictb updated. Please help to check again

dominictb

mollfpr

LGTM!

mollfpr · 2025-07-01T17:08:38Z

@thelullabyy We have a failing job, I'm going to revert this to clean that up. Could you open another one and check if the job is correctly pass? Thank you!

github-actions · 2025-07-02T00:03:29Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.1.74-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mvtglobally · 2025-07-02T01:18:43Z

@dominictb @mollfpr Looks like this PR has been reverted. Should we still QA it?

dominictb · 2025-07-02T01:27:41Z

@mvtglobally No you don't need to for now. Thanks.

github-actions · 2025-07-03T19:43:43Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.74-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

thelullabyy added 2 commits June 25, 2025 17:14

fix: Workspace chat still displays GBR in LHN after changing report w…

c8b0a5d

…orkspace

update test

c7e7521

thelullabyy marked this pull request as ready for review June 25, 2025 14:04

thelullabyy requested a review from a team as a code owner June 25, 2025 14:04

melvin-bot Bot requested a review from dominictb June 25, 2025 14:04

melvin-bot Bot removed the request for review from a team June 25, 2025 14:04

dominictb suggested changes Jun 25, 2025

View reviewed changes

dominictb reviewed Jun 25, 2025

View reviewed changes

refactor code

d60d255

thelullabyy added 2 commits June 27, 2025 12:15

Merge branch 'main' into fix/64452-workspace-chat-still-display-GBR

232f950

remove approver test case

f0bb813

dominictb approved these changes Jun 30, 2025

View reviewed changes

melvin-bot Bot requested a review from mollfpr June 30, 2025 09:35

mollfpr approved these changes Jul 1, 2025

View reviewed changes

mollfpr merged commit 70b3bf9 into Expensify:main Jul 1, 2025
19 checks passed

This was referenced Jul 1, 2025

Investigate workflow job failing on main: test / test (job 1) #65267

Closed

Investigate workflow job failing on main: test / test (job 1) #65271

Closed

mollfpr mentioned this pull request Jul 1, 2025

Revert "Expense - Workspace chat still displays GBR in LHN after changing report workspace" #65275

Merged

51 tasks

github-actions Bot mentioned this pull request Jul 1, 2025

Deploy Checklist: New Expensify 2025-07-01 #65287

Closed

57 tasks

melvin-bot Bot mentioned this pull request Jul 3, 2025

[Due for payment 2025-07-15] [Due for payment 2025-07-10] [$250] Expense - Workspace chat still displays GBR in LHN after changing report workspace #64452

Closed

8 tasks


		await Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${fakeReport.reportID}`, MOCK_REPORT_ACTIONS);

		expect(getIOUReportActionToApproveOrPay(fakeReport, '3')).toMatchObject(MOCK_REPORT_ACTIONS['1']);

Conversation

thelullabyy commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 25, 2025

Uh oh!

dominictb commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dominictb Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Jun 27, 2025

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mollfpr commented Jul 1, 2025

Uh oh!

github-actions Bot commented Jul 2, 2025

Uh oh!

mvtglobally commented Jul 2, 2025

Uh oh!

dominictb commented Jul 2, 2025

Uh oh!

github-actions Bot commented Jul 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thelullabyy commented Jun 25, 2025 •

edited

Loading

dominictb commented Jun 25, 2025 •

edited

Loading