Removing violations for duplicate transactions.

src/components/MoneyReportHeader.tsx

@@ -3,6 +3,7 @@ import React, {useCallback, useContext, useEffect, useMemo, useState} from 'reac
 import {ActivityIndicator, InteractionManager, View} from 'react-native';
 import type {OnyxEntry} from 'react-native-onyx';
 import type {ValueOf} from 'type-fest';
+import useDuplicateTransactionsAndViolations from '@hooks/useDuplicateTransactionsAndViolations';
 import useLoadingBarVisibility from '@hooks/useLoadingBarVisibility';
 import useLocalize from '@hooks/useLocalize';
 import useMobileSelectionMode from '@hooks/useMobileSelectionMode';
@@ -191,6 +192,7 @@ function MoneyReportHeader({
         {canBeMissing: true},
     );
 
+    const {duplicateTransactions, duplicateTransactionViolations} = useDuplicateTransactionsAndViolations(transactions.map((t) => t.transactionID));
     const isExported = useMemo(() => isExportedUtils(reportActions), [reportActions]);
     // wrapped in useMemo to improve performance because this is an operation on array
     const integrationNameFromExportMessage = useMemo(() => {
@@ -1137,7 +1139,9 @@ function MoneyReportHeader({
                         }
                         // it's deleting transaction but not the report which leads to bug (that is actually also on staging)
                         // Money request should be deleted when interactions are done, to not show the not found page before navigating to goBackRoute
-                        InteractionManager.runAfterInteractions(() => deleteMoneyRequest(transaction?.transactionID, requestParentReportAction));
+                        InteractionManager.runAfterInteractions(() =>
+                            deleteMoneyRequest(transaction?.transactionID, requestParentReportAction, duplicateTransactions, duplicateTransactionViolations),
+                        );
                         goBackRoute = getNavigationUrlOnMoneyRequestDelete(transaction.transactionID, requestParentReportAction, false);
                     }
 

src/components/MoneyRequestHeader.tsx

@@ -4,6 +4,7 @@ import React, {useCallback, useContext, useEffect, useMemo, useState} from 'reac
 import {View} from 'react-native';
 import type {OnyxEntry} from 'react-native-onyx';
 import type {ValueOf} from 'type-fest';
+import useDuplicateTransactionsAndViolations from '@hooks/useDuplicateTransactionsAndViolations';
 import useLoadingBarVisibility from '@hooks/useLoadingBarVisibility';
 import useLocalize from '@hooks/useLocalize';
 import useOnyx from '@hooks/useOnyx';
@@ -80,7 +81,7 @@ function MoneyRequestHeader({report, parentReportAction, policy, onBackButtonPre
         {canBeMissing: true},
     );
     const transactionViolations = useTransactionViolations(transaction?.transactionID);
-
+    const {duplicateTransactions, duplicateTransactionViolations} = useDuplicateTransactionsAndViolations(transaction?.transactionID ? [transaction.transactionID] : []);
     const [isDeleteModalVisible, setIsDeleteModalVisible] = useState(false);
     const [downloadErrorModalVisible, setDownloadErrorModalVisible] = useState(false);
     const [dismissedHoldUseExplanation, dismissedHoldUseExplanationResult] = useOnyx(ONYXKEYS.NVP_DISMISSED_HOLD_USE_EXPLANATION, {canBeMissing: true});
@@ -351,9 +352,9 @@ function MoneyRequestHeader({report, parentReportAction, policy, onBackButtonPre
                         throw new Error('Data missing');
                     }
                     if (isTrackExpenseAction(parentReportAction)) {
-                        deleteTrackExpense(report?.parentReportID, transaction.transactionID, parentReportAction, true);
+                        deleteTrackExpense(report?.parentReportID, transaction.transactionID, parentReportAction, duplicateTransactions, duplicateTransactionViolations, true);
                     } else {
-                        deleteMoneyRequest(transaction.transactionID, parentReportAction, true);
+                        deleteMoneyRequest(transaction.transactionID, parentReportAction, duplicateTransactions, duplicateTransactionViolations, true);
                         removeTransaction(transaction.transactionID);
                     }
                     onBackButtonPress();

src/hooks/useDuplicateTransactionsAndViolations.ts

@@ -0,0 +1,141 @@
+import {useMemo} from 'react';
+import type {OnyxCollection} from 'react-native-onyx';
+import CONST from '@src/CONST';
+import ONYXKEYS from '@src/ONYXKEYS';
+import type {Transaction, TransactionViolations} from '@src/types/onyx';
+import useOnyx from './useOnyx';
+
+/**
+ * Selects violations related to provided transaction IDs and if present, the violations of their duplicates.
+ * @param transactionIDs - An array of transaction IDs to fetch their violations for.
+ * @param allTransactionsViolations - A collection of all transaction violations currently in the onyx db.
+ * @returns - A collection of violations related to the transaction IDs and if present, the violations of their duplicates.
+ * @private
+ */
+function selectViolationsWithDuplicates(transactionIDs: string[], allTransactionsViolations: OnyxCollection<TransactionViolations>): OnyxCollection<TransactionViolations> {
+    if (!allTransactionsViolations || !transactionIDs?.length) {
+        return {};
+    }
+
+    const result: OnyxCollection<TransactionViolations> = {};
+
+    for (const transactionID of transactionIDs) {
+        const key = `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`;
+        const transactionViolations = allTransactionsViolations[key];
+
+        if (!transactionViolations) {
+            continue;
+        }
+
+        result[key] = transactionViolations;
+
+        transactionViolations
+            .filter((violations) => violations.name === CONST.VIOLATIONS.DUPLICATED_TRANSACTION)
+            .flatMap((violations) => violations?.data?.duplicates ?? [])
+            .forEach((duplicateID) => {
+                if (!duplicateID) {
+                    return;
+                }
+
+                const duplicateKey = `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${duplicateID}`;
+                const duplicateViolations = allTransactionsViolations[duplicateKey];
+
+                if (duplicateViolations) {
+                    result[duplicateKey] = duplicateViolations;
+                }
+            });
+    }
+
+    return result;
+}
+
+/**
+ * Selects transactions related to provided transaction IDs and if present, the duplicate transactions.
+ * @param transactionIDs - An array of transaction IDs to fetch their transactions for.
+ * @param allTransactions - A collection of all transactions currently in the onyx.
+ * @param duplicateTransactionViolations - A collection of all duplicate transaction violations currently in the onyx.
+ * @returns - A collection of transactions related to the transaction IDs and if present, the duplicate transactions.
+ */
+
+function selectTransactionsWithDuplicates(
+    transactionIDs: string[],
+    allTransactions: OnyxCollection<Transaction>,
+    duplicateTransactionViolations: OnyxCollection<TransactionViolations>,
+): OnyxCollection<Transaction> {
+    if (!allTransactions) {
+        return {};
+    }
+
+    const result: OnyxCollection<Transaction> = {};
+
+    for (const transactionID of transactionIDs) {
+        const key = `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`;
+        const transaction = allTransactions[key];
+        if (transaction) {
+            result[key] = transaction;
+        }
+
+        const transactionViolations = duplicateTransactionViolations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`];
+
+        if (!transactionViolations) {
+            continue;
+        }
+
+        transactionViolations
+            .filter((violations) => violations.name === CONST.VIOLATIONS.DUPLICATED_TRANSACTION)
+            .flatMap((violations) => violations?.data?.duplicates ?? [])
+            .forEach((duplicateID) => {
+                if (!duplicateID) {
+                    return;
+                }
+
+                const duplicateKey = `${ONYXKEYS.COLLECTION.TRANSACTION}${duplicateID}`;
+                const duplicateTransaction = allTransactions[duplicateKey];
+
+                if (duplicateTransaction) {
+                    result[duplicateKey] = duplicateTransaction;
+                }
+            });
+    }
+    return result;
+}
+
+type DuplicateTransactionsAndViolations = {
+    duplicateTransactions: OnyxCollection<Transaction>;
+    duplicateTransactionViolations: OnyxCollection<TransactionViolations>;
+};
+
+/**
+ * A hook to fetch transactions, their violations and if present, the duplicate transactions and their violations.
+ * @param transactionIDs - Array of transaction IDs to check for duplicates.
+ * @returns - An object containing duplicate transactions and their violations.
+ */
+function useDuplicateTransactionsAndViolations(transactionIDs: string[]): DuplicateTransactionsAndViolations {
+    const violationsSelectorMemo = useMemo(() => {
+        return (allTransactionsViolations: OnyxCollection<TransactionViolations>) => selectViolationsWithDuplicates(transactionIDs, allTransactionsViolations);
+    }, [transactionIDs]);
+
+    const [duplicateTransactionViolations] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, {
+        canBeMissing: true,
+        selector: violationsSelectorMemo,
+    });
+
+    const transactionSelector = useMemo(() => {
+        return (allTransactions: OnyxCollection<Transaction>) => selectTransactionsWithDuplicates(transactionIDs, allTransactions, duplicateTransactionViolations);
+    }, [transactionIDs, duplicateTransactionViolations]);
+
+    const [duplicateTransactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {
+        canBeMissing: true,
+        selector: transactionSelector,
+    });
+
+    return useMemo(
+        () => ({
+            duplicateTransactions,
+            duplicateTransactionViolations,
+        }),
+        [duplicateTransactions, duplicateTransactionViolations],
+    );
+}
+
+export default useDuplicateTransactionsAndViolations;

src/hooks/useSelectedTransactionsActions.ts

@@ -21,6 +21,7 @@ import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
 import type {OriginalMessageIOU, Report, ReportAction, Session, Transaction} from '@src/types/onyx';
+import useDuplicateTransactionsAndViolations from './useDuplicateTransactionsAndViolations';
 import useLocalize from './useLocalize';
 import useOnyx from './useOnyx';
 import useReportIsArchived from './useReportIsArchived';
@@ -45,6 +46,7 @@ function useSelectedTransactionsActions({
 }) {
     const {selectedTransactionIDs, clearSelectedTransactions} = useSearchContext();
     const [allTransactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {canBeMissing: false});
+    const {duplicateTransactions, duplicateTransactionViolations} = useDuplicateTransactionsAndViolations(selectedTransactionIDs);
     const isReportArchived = useReportIsArchived(report?.reportID);
     const selectedTransactions = useMemo(
         () =>
@@ -62,6 +64,7 @@ function useSelectedTransactionsActions({
     const [isDeleteModalVisible, setIsDeleteModalVisible] = useState(false);
     const isTrackExpenseThread = isTrackExpenseReport(report);
     const isInvoice = isInvoiceReport(report);
+
     let iouType: IOUType = CONST.IOU.TYPE.SUBMIT;
 
     if (isTrackExpenseThread) {
@@ -87,15 +90,15 @@ function useSelectedTransactionsActions({
                 return;
             }
 
-            deleteMoneyRequest(transactionID, action, undefined, deletedTransactionIDs);
+            deleteMoneyRequest(transactionID, action, duplicateTransactions, duplicateTransactionViolations, false, deletedTransactionIDs);
             deletedTransactionIDs.push(transactionID);
         });
         clearSelectedTransactions(true);
         if (allTransactionsLength - transactionsWithActions.length <= 1) {
             turnOffMobileSelectionMode();
         }
         setIsDeleteModalVisible(false);
-    }, [allTransactionsLength, reportActions, selectedTransactionIDs, clearSelectedTransactions]);
+    }, [duplicateTransactions, duplicateTransactionViolations, allTransactionsLength, reportActions, selectedTransactionIDs, clearSelectedTransactions]);
 
     const showDeleteModal = useCallback(() => {
         setIsDeleteModalVisible(true);