MED Refactor ShowContextMenuContext to pass isReportArchived instead of rNVPs by thelullabyy · Pull Request #65179 · Expensify/App

thelullabyy · 2025-06-30T11:16:34Z

Explanation of Change

Fixed Issues

$ #64933
PROPOSAL: #64933 (comment)

Tests

Open app
Verify context menu open properly e.g report, reportAction, link, ...

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open app
Verify context menu open properly e.g report, reportAction, link, ...

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android_web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-06-30T11:28:28Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-06-30T12:34:39Z

            anchor: null,
            report,
-            reportNameValuePairs: undefined,
+            isReportArchived,


Why do we need to add isReportArchived value here? The previous logic is using undefined value

I've fixed this

DylanDylann · 2025-06-30T12:34:55Z

            checkIfContextMenuActive: () => {},
            onShowContextMenu: () => {},
-            reportNameValuePairs: undefined,
+            isReportArchived,


DylanDylann · 2025-06-30T12:35:50Z

        () => ({
            anchor: popoverAnchorRef.current,
            report,
-            reportNameValuePairs,


Let's remove reportNameValuePairs prop totally in this component

@DylanDylann updated

DylanDylann · 2025-06-30T12:37:37Z

Also please remove reportNameValuePairs parameter and use isReportArchived param in getLastMessageTextForReport function

thelullabyy · 2025-06-30T13:18:03Z

Also please remove reportNameValuePairs parameter and use isReportArchived param in getLastMessageTextForReport function

@DylanDylann I've updated this func, please check again

DylanDylann · 2025-06-30T13:57:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-30.at.21.06.16.mov

Android: mWeb Chrome

Screen.Recording.2025-06-30.at.21.05.42.mov

iOS: HybridApp

Screen.Recording.2025-06-30.at.21.04.58.mov

iOS: mWeb Safari

Screen.Recording.2025-06-30.at.21.03.28.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-30.at.21.00.54.mov

MacOS: Desktop

Screen.Recording.2025-06-30.at.21.02.24.mov

DylanDylann

LGTM

tgolen · 2025-06-30T14:56:35Z

    onShowContextMenu: (callback) => callback(),
    report: undefined,
-    reportNameValuePairs: undefined,
+    isReportArchived: undefined,


NAB: This could default to false since it's a boolean (and that's what the default parameter does).

tgolen · 2025-06-30T14:57:50Z

-    policy?: OnyxEntry<Policy>,
-    reportNameValuePairs?: OnyxInputOrEntry<ReportNameValuePairs>,
-): string {
+function getLastMessageTextForReport(report: OnyxEntry<Report>, lastActorDetails: Partial<PersonalDetails> | null, policy?: OnyxEntry<Policy>, isReportArchived?: boolean): string {


Suggested change

function getLastMessageTextForReport(report: OnyxEntry<Report>, lastActorDetails: Partial<PersonalDetails> | null, policy?: OnyxEntry<Policy>, isReportArchived?: boolean): string {

function getLastMessageTextForReport(report: OnyxEntry<Report>, lastActorDetails: Partial<PersonalDetails> | null, policy?: OnyxEntry<Policy>, isReportArchived = false): string {

Default this to false to be consistent with the other places we are using a parameter like this.

tgolen · 2025-06-30T14:59:54Z

        const lastActorDetails = lastActorAccountID ? (personalDetails?.[lastActorAccountID] ?? null) : null;
        const lastActorDisplayName = getLastActorDisplayName(lastActorDetails);
-        const lastMessageTextFromReport = getLastMessageTextForReport(report, lastActorDetails, undefined, reportNameValuePairs);
+        const lastMessageTextFromReport = getLastMessageTextForReport(report, lastActorDetails, undefined, !!reportNameValuePairs?.private_isArchived);


You should probably use result.private_isArchived here since it's already defined above. Then, up above where result.private_isArchived is defined, be sure to add !! in front of the NVP reference.

@tgolen I updated to use !!result.private_isArchived directly in getLastMessageTextForReport since the private_isArchived type is string, we cannot assign it to boolean value

tgolen · 2025-06-30T15:00:30Z

    let lastMessageTextFromReport = lastMessageTextFromReportProp;
    if (!lastMessageTextFromReport) {
-        lastMessageTextFromReport = getLastMessageTextForReport(report, lastActorDetails, policy, reportNameValuePairs);
+        lastMessageTextFromReport = getLastMessageTextForReport(report, lastActorDetails, policy, !!reportNameValuePairs?.private_isArchived);


Same here. Use result.private_isArchived and add !! to the definition above.

tgolen · 2025-06-30T15:01:35Z

    anchor: null,
    report: undefined,
-    reportNameValuePairs: undefined,
+    isReportArchived: undefined,


Default to false

DylanDylann · 2025-07-01T02:47:40Z

@thelullabyy Please resolve conflict

thelullabyy · 2025-07-01T13:25:21Z

@DylanDylann I've resolved conflicts, pls check again

DylanDylann · 2025-07-01T14:16:06Z

@tgolen All your

OSBotify · 2025-07-01T20:42:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-02T00:03:53Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.1.74-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-03T19:44:07Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.74-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

feat: refactor show context menu context

e0344f8

thelullabyy changed the title ~~feat: refactor show context menu context~~ MED Refactor ShowContextMenuContext to pass isReportArchived instead of rNVPs Jun 30, 2025

thelullabyy marked this pull request as ready for review June 30, 2025 11:28

thelullabyy requested a review from a team as a code owner June 30, 2025 11:28

melvin-bot Bot requested a review from DylanDylann June 30, 2025 11:28

melvin-bot Bot removed the request for review from a team June 30, 2025 11:28

DylanDylann reviewed Jun 30, 2025

View reviewed changes

chore: update getLastMessageTextForReport

fedd2df

DylanDylann approved these changes Jun 30, 2025

View reviewed changes

melvin-bot Bot requested a review from tgolen June 30, 2025 14:08

tgolen requested changes Jun 30, 2025

View reviewed changes

fix: comments

b1658e2

tgolen previously approved these changes Jul 1, 2025

View reviewed changes

chore: merge main

2547aec

thelullabyy dismissed tgolen’s stale review via 2547aec July 1, 2025 13:21

DylanDylann approved these changes Jul 1, 2025

View reviewed changes

melvin-bot Bot requested a review from tgolen July 1, 2025 14:04

tgolen approved these changes Jul 1, 2025

View reviewed changes

tgolen merged commit ea893a7 into Expensify:main Jul 1, 2025
20 checks passed

github-actions Bot mentioned this pull request Jul 1, 2025

Deploy Checklist: New Expensify 2025-07-01 #65287

Closed

57 tasks

BlameGPT mentioned this pull request Jul 2, 2025

[$250] Attachment- Corrupted PDF isn't triggering the error modal if sent with drag & drop #65319

Closed

8 tasks

BlameGPT mentioned this pull request Jul 3, 2025

Reports - After deleting report, filter buttons are not responsive and do not open list #65410

Closed

16 tasks

melvin-bot Bot mentioned this pull request Jul 3, 2025

[Due for payment 2025-07-10] [$250] MED Refactor ShowContextMenuContext to pass isReportArchived instead of rNVPs #64933

Closed

	function getLastMessageTextForReport(report: OnyxEntry<Report>, lastActorDetails: Partial<PersonalDetails> \| null, policy?: OnyxEntry<Policy>, isReportArchived?: boolean): string {
	function getLastMessageTextForReport(report: OnyxEntry<Report>, lastActorDetails: Partial<PersonalDetails> \| null, policy?: OnyxEntry<Policy>, isReportArchived = false): string {

Conversation

thelullabyy commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jun 30, 2025

Uh oh!

thelullabyy commented Jun 30, 2025

Uh oh!

DylanDylann commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jul 1, 2025

Uh oh!

thelullabyy commented Jul 1, 2025

Uh oh!

DylanDylann commented Jul 1, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 1, 2025

Uh oh!

github-actions Bot commented Jul 2, 2025

Uh oh!

github-actions Bot commented Jul 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thelullabyy commented Jun 30, 2025 •

edited

Loading

DylanDylann commented Jun 30, 2025 •

edited

Loading