Skip to content

[CP Staging] Fix invisible sidebar on Safari #65202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneetlath merged 1 commit into from
Jun 30, 2025
Merged

[CP Staging] Fix invisible sidebar on Safari #65202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...hes/react-navigation/@react-navigation+stack+7.3.3+003+fix-invisible-sidebar-safari.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/node_modules/@react-navigation/stack/lib/module/views/Stack/CardStack.js b/node_modules/@react-navigation/stack/lib/module/views/Stack/CardStack.js
index e8d9f78..4bb7737 100644
--- a/node_modules/@react-navigation/stack/lib/module/views/Stack/CardStack.js
+++ b/node_modules/@react-navigation/stack/lib/module/views/Stack/CardStack.js
@@ -429,7 +429,7 @@ export class CardStack extends React.Component {
index: index,
interpolationIndex: interpolationIndex,
modal: isModal,
- active: index === routes.length - 1,
+ active: index === routes.length - 1 || shouldNotDetachScreen,
focused: focused,
opening: openingRouteKeys.includes(route.key),
closing: closingRouteKeys.includes(route.key),
5 changes: 5 additions & 0 deletions patches/react-navigation/details.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,8 @@
- E/App issue: [#48150](https://github.com/Expensify/App/issues/48150)
- PR Introducing Patch: [#48151](https://github.com/Expensify/App/pull/48151)
- PR Updating Patch: [#64155](https://github.com/Expensify/App/pull/64155)

### [@react-navigation+stack+7.3.3+003+fix-invisible-sidebar-safari.patch](@react-navigation+stack+7.3.3+003+fix-invisible-sidebar-safari.patch)
- Reason: Sidebar is invisible on the safari
- Upstream PR/issue: N/A
- E/App issue: [#65119](https://github.com/Expensify/App/issues/65119)
Loading