Skip to content

fix: Expensify card - Connect bank account RHP does not open smoothly. #65221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flodnv merged 1 commit into from
Jul 2, 2025
Merged

fix: Expensify card - Connect bank account RHP does not open smoothly. #65221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/Lottie/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,13 @@ function Lottie({source, webStyle, shouldLoadAfterInteractions, ...props}: Props
// we'll just render an empty view as the fallback to prevent
// 1. heavy rendering, see issues: https://github.com/Expensify/App/issues/34696 and https://github.com/Expensify/App/issues/47273
// 2. lag on react navigation transitions, see issue: https://github.com/Expensify/App/issues/44812
if (isError || appState.isBackground || !animationFile || splashScreenState !== CONST.BOOT_SPLASH_STATE.HIDDEN || (!isInteractionComplete && shouldLoadAfterInteractions)) {
if (
isError ||
appState.isBackground ||
!animationFile ||
splashScreenState !== CONST.BOOT_SPLASH_STATE.HIDDEN ||
((!isInteractionComplete || hasNavigatedAway) && shouldLoadAfterInteractions)
) {
return (
<View
style={[aspectRatioStyle, props.style]}
Expand Down
1 change: 1 addition & 0 deletions src/components/Section/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ function Section({
webStyle={styles.h100}
autoPlay
loop
shouldLoadAfterInteractions={shouldUseNarrowLayout}
/>
) : (
<ImageSVG
Expand Down
Loading