-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Sync drafts between devices #65463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sync drafts between devices #65463
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
acaa5ec
Sync drafts between devices
chuckdries 71eccaa
Migrate drafts from collection key to NVP key; also use for LHN
chuckdries 7b009f7
Fix draft optimistic update clobbering other drafts
chuckdries f8fe085
Clean up NVP drafts in local policy deletion cascades
chuckdries 7c6fceb
Fix lint and style and types
chuckdries ba40f3f
Use debounce:true for composer onClear to ensure sent messages actual…
chuckdries cd7c48a
Clean up shouldDebounceSavedComment
chuckdries dbcdd4c
Clean up COLLECTION.REPORT_DRAFT_COMMENT
chuckdries 5bf301c
Address lint error
chuckdries 88fe5c9
Address PR feedback, add useDiffPrevious hook
chuckdries ea52964
Address lint errors
chuckdries fb51045
Fix lodash import statement
chuckdries 31687c6
Remove SilentCommentUpdater
chuckdries File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import union from 'lodash/union'; | ||
| import {useMemo} from 'react'; | ||
| import usePrevious from './usePrevious'; | ||
|
|
||
| /** This hook provides a list of which keys changed in an object vs the previous render | ||
| * akin to `sourceValue` for collections. Generally, using this hook at all is an anti-pattern. | ||
| * Avoid it at all costs */ | ||
| export default function useDiffPrevious<T extends Record<string, unknown>>(value: T): string[] { | ||
| const previous = usePrevious(value); | ||
| const diff = useMemo(() => { | ||
| const allKeys = union(Object.keys(value), Object.keys(previous)); | ||
| return allKeys.filter((key) => value[key] !== previous[key]); | ||
| }, [value, previous]); | ||
|
|
||
| return diff; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| type SaveReportDraftCommentParams = { | ||
| reportID: string; | ||
| comment: string; | ||
| }; | ||
|
|
||
| export default SaveReportDraftCommentParams; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.