Skip to content

[CP Staging] Revert "Fix: New message marker is not displayed on the first message in expense report"#65522

Merged
mountiny merged 1 commit into
mainfrom
revert-64859-issue-63427
Jul 5, 2025
Merged

[CP Staging] Revert "Fix: New message marker is not displayed on the first message in expense report"#65522
mountiny merged 1 commit into
mainfrom
revert-64859-issue-63427

Conversation

@mountiny

@mountiny mountiny commented Jul 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #64859

Straight revert

Fixes #65487

Please test the regression from the linked PR

@mountiny mountiny self-assigned this Jul 5, 2025
@mountiny mountiny requested a review from a team as a code owner July 5, 2025 05:46
@melvin-bot melvin-bot Bot requested a review from marcaaron July 5, 2025 05:46
@melvin-bot

melvin-bot Bot commented Jul 5, 2025

Copy link
Copy Markdown

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team July 5, 2025 05:46
srikarparsi
srikarparsi approved these changes Jul 5, 2025
View reviewed changes

@srikarparsi srikarparsi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight revert

@mountiny mountiny merged commit 3f03a21 into main Jul 5, 2025
20 of 22 checks passed
@mountiny mountiny deleted the revert-64859-issue-63427 branch July 5, 2025 05:52
@melvin-bot melvin-bot Bot added the Emergency label Jul 5, 2025
@melvin-bot

melvin-bot Bot commented Jul 5, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Jul 5, 2025
@mountiny

mountiny commented Jul 5, 2025

Copy link
Copy Markdown
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Jul 5, 2025
@mountiny @OSBotify
Merge pull request #65522 from Expensify/revert-64859-issue-63427
28fe926 
[CP Staging] Revert "Fix: New message marker is not displayed on the first message in expense report"

(cherry picked from commit 3f03a21)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 5, 2025
@github-actions github-actions Bot mentioned this pull request Jul 5, 2025
Closed
63 tasks
@OSBotify

OSBotify commented Jul 5, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 5, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.76-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

github-actions Bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.76-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@c3024 c3024 mentioned this pull request Jul 8, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcaaron marcaaron Awaiting requested review from marcaaron

1 more reviewer

@srikarparsi srikarparsi srikarparsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expense - New message marker above "exported to CSV" does not disappear after reopening report

3 participants

@mountiny @OSBotify @srikarparsi