Skip to content

Render ChatBubbleCell only if it's needed #65570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 5 commits into from
Jul 14, 2025
Merged

Render ChatBubbleCell only if it's needed #65570

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a387c1e
Render ChatBubbleCell only if it's needed
sosek108 Jul 7, 2025
18066f3
Merge branch 'main' into perf/optimize-chat-bubble-cell-rendering
sosek108 Jul 11, 2025
3d084de
Eslint fixes
sosek108 Jul 11, 2025
7dc54b3
Small code cleanup
sosek108 Jul 11, 2025
a67eb54
Merge branch 'main' into perf/optimize-chat-bubble-cell-rendering
sosek108 Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/components/TransactionItemRow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,10 @@ function TransactionItemRow({
],
);
const safeColumnWrapperStyle = columnWrapperStyles ?? [styles.p3, styles.expenseWidgetRadius];
const shouldRenderChatBubbleCell = useMemo(() => {
return columns?.includes(CONST.REPORT.TRANSACTION_LIST.COLUMNS.COMMENTS) ?? false;
}, [columns]);

return (

@ZhenjaHorbach ZhenjaHorbach Jul 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment
But let's add an empty line before return

@sosek108 sosek108 Jul 11, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ZhenjaHorbach ZhenjaHorbach Jul 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn
Now we have TS issues 😅

@ZhenjaHorbach ZhenjaHorbach Jul 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's not our issues
Let's try to update a branch to the latest version of main

<View
style={[styles.flex1]}
Expand Down Expand Up @@ -479,11 +483,13 @@ function TransactionItemRow({
missingFieldError={missingFieldError}
/>
</View>
<ChatBubbleCell
transaction={transactionItem}
containerStyles={[styles.mt2]}
isInSingleTransactionReport={isInSingleTransactionReport}
/>
{shouldRenderChatBubbleCell && (
<ChatBubbleCell
transaction={transactionItem}
containerStyles={[styles.mt2]}
isInSingleTransactionReport={isInSingleTransactionReport}
/>
)}
</View>
</View>
</Animated.View>
Expand Down
Loading