[CP Staging] fix: not here page open after back to perdiem page#65630
Conversation
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-07-08.at.6.15.42.PM.movAndroid: mWeb ChromeScreen.Recording.2025-07-08.at.6.18.05.PM.moviOS: HybridAppScreen.Recording.2025-07-08.at.6.15.42.PM.moviOS: mWeb SafariScreen.Recording.2025-07-08.at.6.11.08.PM.movMacOS: Chrome / SafariScreen.Recording.2025-07-08.at.6.08.13.PM.movMacOS: DesktopScreen.Recording.2025-07-08.at.6.12.43.PM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…-when-back-to-perdiem (cherry picked from commit 8effcea) (cherry-picked to staging by mountiny)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.77-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.77-2 🚀
|
Explanation of Change
This PR updates the per-diem route to align with the new navigation v7.
Fixed Issues
$ #65553
PROPOSAL: #65553 (comment)
Tests
Precondition:
Workspace has per diem rates.
Offline tests
Same as tests above
QA Steps
Same as tests above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-07-08.at.16.29.02.mov
Android: mWeb Chrome
Screen.Recording.2025-07-08.at.16.30.27.mov
iOS: Native
Screen.Recording.2025-07-08.at.16.25.58.mov
iOS: mWeb Safari
Screen.Recording.2025-07-08.at.16.27.19.mov
MacOS: Chrome / Safari
Screen.Recording.2025-07-08.at.16.18.33.mov
MacOS: Desktop
Screen.Recording.2025-07-08.at.16.21.36.mov