perf: getBankAccountRoute usage optimization by martasudol · Pull Request #65845 · Expensify/App

martasudol · 2025-07-10T11:46:28Z

Explanation of Change

getBankAccountRoute function itself is fast in a single call (2-5ms) but we call it so many times that its combined time grows extremely. This PR makes a single call to this function instead of precomputing the route for all items.

Fixed Issues

$ #65868

Tests

Case 1:

Create a expense
Navigate to the money report view.

Case 2 (Precondition: User has submitted a personal expense report that needs reimbursement):

Navigate to the expense report that shows "Pay" button
Click on the "Pay" button dropdown arrow
Select "Add Bank Account" option from the payment methods
Expected: User is navigated to personal bank account setup page (/settings/add-bank-account)

Case 3: (Precondition: User has received an invoice in an individual invoice room)

Open an invoice that needs payment
Click on the "Settle up" button
Select "Pay as an individual" option
Click "Add Bank Account" from the submenu
Expected: User is navigated to personal bank account setup
Verify: Submenu shows correctly, navigation works

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Nagranie.z.ekranu.2025-07-10.o.16.30.24.mov

Android: mWeb Chrome

Nagranie.z.ekranu.2025-07-10.o.16.31.59.mov

iOS: Native

Nagranie.z.ekranu.2025-07-10.o.15.54.00.mov

iOS: mWeb Safari

Nagranie.z.ekranu.2025-07-10.o.16.09.29.mov

MacOS: Chrome / Safari

Nagranie.z.ekranu.2025-07-10.o.16.20.08.mov

MacOS: Desktop

Nagranie.z.ekranu.2025-07-10.o.16.27.41.mov

Measurements

Before: 140ms
After: 0ms

Before:

After:

melvin-bot · 2025-07-10T14:34:08Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Changes look good to me

c3024 · 2025-07-11T10:43:34Z

                onPress={confirm}
                enablePaymentsRoute={ROUTES.IOU_SEND_ENABLE_PAYMENTS}
-                addBankAccountRoute={bankAccountRoute}
+                chatReport={chatReport}


It looks like SettlementButton uses chatReportID to fetch the chat report via useOnyx. It does not use this chatReport prop. The chat report won’t be available here because chatReportID is not passed to this component.

c3024 · 2025-07-11T10:54:00Z

                                onSuccessfulKYC={() => Navigation.navigate(ROUTES.ENABLE_PAYMENTS)}
                                enablePaymentsRoute={ROUTES.ENABLE_PAYMENTS}
-                                addBankAccountRoute={ROUTES.BANK_ACCOUNT_PERSONAL}
+                                chatReport={report}


We are replacing a static route here. I think we should match this with the chatReportID passed here.

However, the function getBankAccountRoute does not seem to ever return the route being replaced here.

Suggested change

chatReport={report}

chatReport={targetReport}

@TMisiukiewicz

The old route was ROUTES.BANK_ACCOUNT_PERSONAL. The function getBankAccountRoute does not return this route. Is this okay?

hmm good point, I have to dig a little bit since I haven't worked on this PR originally

@c3024 I couldn't figure out the proper condition to incorporate this path into getBankAccountRoute. Instead, I brought back the addBankAccountRoute param as optional, so if it's defined, it will use it in first place. What do you think about this?

…-perf

TMisiukiewicz · 2025-07-15T12:45:08Z

Since Marta is OOO this week I took it over. @c3024 I addressed your comments, could you take a look again?

c3024 · 2025-07-15T13:20:31Z

+    /** Chat report for calculating bank account routes */
+    chatReport?: OnyxEntry<Report>;


Suggested change

/** Chat report for calculating bank account routes */

chatReport?: OnyxEntry<Report>;

This is not required because chatReportID is a prop for SettlementButton and it fetches report with useOnyx.

c3024 · 2025-07-15T13:21:15Z

                confirmApproval={confirmApproval}
                enablePaymentsRoute={ROUTES.ENABLE_PAYMENTS}
-                addBankAccountRoute={bankAccountRoute}
+                chatReport={chatReport}


Suggested change

chatReport={chatReport}

We are passing chatReportID. This is enough for the report inside the SettlementButton.

c3024 · 2025-07-15T13:27:45Z

                onPress={confirmPayment}
                enablePaymentsRoute={ROUTES.ENABLE_PAYMENTS}
-                addBankAccountRoute={bankAccountRoute}
+                chatReport={chatReport}


Not required because the prop chatReportID is already available.

Suggested change

chatReport={chatReport}

c3024 · 2025-07-15T13:35:46Z

There are conflicts too.

TMisiukiewicz · 2025-07-15T14:09:36Z

@c3024 done, thanks for spotting those 🙏

…-perf

c3024 · 2025-07-16T10:42:24Z

                                onSuccessfulKYC={() => Navigation.navigate(ROUTES.ENABLE_PAYMENTS)}
                                enablePaymentsRoute={ROUTES.ENABLE_PAYMENTS}
-                                addBankAccountRoute={ROUTES.BANK_ACCOUNT_PERSONAL}
                                addDebitCardRoute={ROUTES.SETTINGS_ADD_DEBIT_CARD}


We should retain this, right?

Suggested change

addDebitCardRoute={ROUTES.SETTINGS_ADD_DEBIT_CARD}

addBankAccountRoute={ROUTES.BANK_ACCOUNT_PERSONAL}

addDebitCardRoute={ROUTES.SETTINGS_ADD_DEBIT_CARD}

c3024 · 2025-07-16T10:54:35Z

                            pressOnEnter
                            onPress={submitAndNavigateToNextPage}
                            enablePaymentsRoute={ROUTES.IOU_SEND_ENABLE_PAYMENTS}
-                            addBankAccountRoute={bankAccountRoute}


I missed this last time. SettlementButton does not get chatReportID prop here so it cannot know the correct route. We can pass the reportID from IOURequestStepAmount to MoneyRequestAmountForm and then to SettlementButton.

TMisiukiewicz · 2025-07-16T12:04:58Z

@c3024 thanks, updated the branch with your suggestions

c3024 · 2025-07-16T14:49:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

bankAndroid.mov

Android: mWeb Chrome

bankAndroidmWeb.mov

iOS: HybridApp

bankiOS.mov

iOS: mWeb Safari

bankiOSmWeb.mov

MacOS: Chrome / Safari

bankChrome1.mov

bankChrome2.mov

MacOS: Desktop

bankDesktop.mov

c3024

LGTM!

mountiny

Going to move this one ahead as its very exciting perf improvement!

github-actions · 2025-07-18T05:13:55Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.83-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-21T16:37:48Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.83-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

martasudol added 2 commits July 10, 2025 13:45

perf: getBankAccountRoute usage optimization

f319d0e

perf: getBankAccountRoute usage optimization

58a9388

martasudol marked this pull request as ready for review July 10, 2025 14:33

martasudol requested a review from a team as a code owner July 10, 2025 14:33

melvin-bot Bot requested review from srikarparsi and removed request for a team July 10, 2025 14:34

mountiny assigned martasudol Jul 10, 2025

mountiny previously approved these changes Jul 10, 2025

View reviewed changes

mountiny requested a review from c3024 July 10, 2025 14:45

srikarparsi previously approved these changes Jul 10, 2025

View reviewed changes

c3024 suggested changes Jul 11, 2025

View reviewed changes

TMisiukiewicz added 2 commits July 15, 2025 14:27

Merge remote-tracking branch 'upstream/main' into getBankAccountRoute…

3fc2ac8

…-perf

address code review comments

8cc56f4

TMisiukiewicz dismissed stale reviews from srikarparsi and mountiny via 8cc56f4 July 15, 2025 12:44

mountiny requested a review from c3024 July 15, 2025 13:06

c3024 suggested changes Jul 15, 2025

View reviewed changes

TMisiukiewicz added 2 commits July 15, 2025 16:07

Merge branch 'main' into getBankAccountRoute-perf

645371c

remove unnecessary chatReport calls

79faf46

TMisiukiewicz added 4 commits July 16, 2025 08:54

Merge remote-tracking branch 'upstream/main' into getBankAccountRoute…

3f2b0c0

…-perf

remove unnecessary chatReport

ab9c06b

fix typecheck

1a8d7a6

fix typecheck

57bfb32

TMisiukiewicz force-pushed the getBankAccountRoute-perf branch from b1eca75 to 57bfb32 Compare July 16, 2025 09:06

bring back optional addBankAccountRoute to KYCWall

7d26409

c3024 suggested changes Jul 16, 2025

View reviewed changes

TMisiukiewicz added 3 commits July 16, 2025 13:55

Merge branch 'main' into getBankAccountRoute-perf

3d17e71

add addBankAccountRoute to KYCWall

a4acaf9

pass chatReportID down to SettlementButton

e568570

TMisiukiewicz added 2 commits July 16, 2025 14:15

fix lint-changed

2d5cfd3

rewrite IOURequestStepTaxAmountPage to useOnyx

2c5d44b

c3024 approved these changes Jul 16, 2025

View reviewed changes

melvin-bot Bot requested a review from srikarparsi July 16, 2025 14:58

mountiny approved these changes Jul 16, 2025

View reviewed changes

mountiny merged commit 043c341 into Expensify:main Jul 16, 2025
18 checks passed

github-actions Bot mentioned this pull request Jul 18, 2025

Deploy Checklist: New Expensify 2025-07-18 #66687

Closed

72 tasks

c3024 mentioned this pull request Jul 21, 2025

Remove remaining withOnyx HOCs batch 4 #66234

Merged

51 tasks

adhorodyski deleted the getBankAccountRoute-perf branch July 21, 2025 12:36

melvin-bot Bot mentioned this pull request Jul 21, 2025

[Due for payment 2025-07-28] Optimize getBankAccountRoute #65868

Closed

		/** Chat report for calculating bank account routes */
		chatReport?: OnyxEntry<Report>;

	addDebitCardRoute={ROUTES.SETTINGS_ADD_DEBIT_CARD}
	addBankAccountRoute={ROUTES.BANK_ACCOUNT_PERSONAL}
	addDebitCardRoute={ROUTES.SETTINGS_ADD_DEBIT_CARD}

Conversation

martasudol commented Jul 10, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Case 1:

Case 2 (Precondition: User has submitted a personal expense report that needs reimbursement):

Case 3: (Precondition: User has received an invoice in an individual invoice room)

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Measurements

Uh oh!

melvin-bot Bot commented Jul 10, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

c3024 Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c3024 Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz commented Jul 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c3024 commented Jul 15, 2025

Uh oh!

TMisiukiewicz commented Jul 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz commented Jul 16, 2025

Uh oh!

c3024 commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 18, 2025

Uh oh!

github-actions Bot commented Jul 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

martasudol commented Jul 10, 2025 •

edited by mountiny

Loading

c3024 Jul 11, 2025 •

edited

Loading

c3024 Jul 11, 2025 •

edited

Loading

c3024 commented Jul 16, 2025 •

edited

Loading