fix: unify invite message text by daledah · Pull Request #65888 · Expensify/App

daledah · 2025-07-10T17:04:54Z

Explanation of Change

Fixed Issues

$ #65314
PROPOSAL: #65314 (comment)

Tests

Create a group chat
Invite 1 member
Go back to LHN
Verify that: the last message text shows "You: invited 1 member"
Open search router
Verify that: the last message text shows "You: invited 1 member"

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a group chat
Invite 1 member
Go back to LHN
Verify that: the last message text shows "You: invited 1 member"
Open search router
Verify that: the last message text shows "You: invited 1 member"

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-07-11.at.00.03.19.mov

Android: mWeb Chrome

Screen.Recording.2025-07-11.at.00.02.26.mov

iOS: Native

Screen.Recording.2025-07-11.at.00.03.29.mov

iOS: mWeb Safari

Screen.Recording.2025-07-11.at.00.03.42.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-11.at.00.04.00.mov

MacOS: Desktop

Screen.Recording.2025-07-11.at.00.04.18.mov

melvin-bot · 2025-07-10T17:26:01Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eh2077 · 2025-07-14T13:04:29Z

+    if (
+        !isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.INVITE_TO_ROOM) &&
+        !isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.REMOVE_FROM_ROOM)
+    ) {
+        return '';


App/src/CONST/index.ts

Lines 1253 to 1258 in fc59fcb

ROOM_CHANGE_LOG: {

INVITE_TO_ROOM: 'INVITETOROOM',

REMOVE_FROM_ROOM: 'REMOVEFROMROOM',

LEAVE_ROOM: 'LEAVEROOM',

UPDATE_ROOM_DESCRIPTION: 'UPDATEROOMDESCRIPTION',

},

For system messages of the other two types, is it expected to make them empty?

We fallback if lastMessageTextFromReport is empty here:

App/src/libs/OptionsListUtils.ts

Line 884 in 9a88559

return lastMessageTextFromReport || (report?.lastMessageText ?? '');

And IMO the other cases are out of scope for this PR and we should handle it in another issue if needed.

eh2077 · 2025-07-14T13:08:23Z

        lastMessageTextFromReport = getPolicyChangeMessage(lastReportAction);
    } else if (isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.TRAVEL_UPDATE)) {
        lastMessageTextFromReport = getTravelUpdateMessage(lastReportAction);
+    } else if (isRoomChangeLogAction(lastReportAction)) {


Can you take a look at this method? I think it's ideal to have same logic with LHN messages

App/src/libs/ReportActionsUtils.ts

Line 379 in 4668539

function isInviteOrRemovedAction(

I'm seeing a possible BE bug here: when removing a member from a WS Room, the action is actually CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.REMOVE_FROM_ROOM, not CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.REMOVE_FROM_ROOM:

And when adding members, there's no messages at all.

cc @aldo-expensify

What would be the possible BE bug?

Incorrect message when removing a member of a WS room?

Missing message when adding someone to a WS room?

both?

I'm not familiar with these message, so I'll need to investigate

@aldo-expensify There's 2 bugs:

When removing a member, BE sends incorrect actionName for report action.

When adding a member, BE doesn't send any report actions a.k.a. no messages displayed.

Friendly bump @aldo-expensify, could you give an update on the above issue once you have a chance?

@aldo-expensify There's 2 bugs:

When removing a member, BE sends incorrect actionName for report action.

Regarding this one, from looking in the backend, it appears to be by design that in some cases we send a POLICY_CHANGE_LOG.REMOVE_FROM_ROOM and sometimes we don't. I think I understand from the code in the backend that we only create this POLICY_CHANGE_LOG.REMOVE_FROM_ROOM if the account removed is not a member of the workspace.

@jasperhuangg could you help me with verifying if this is a bug since you worked on this here https://github.com/Expensify/Auth/pull/8642/files 🙏

When adding a member, BE doesn't send any report actions a.k.a. no messages displayed.

Seems like the backend only logs inviting someone if:

The room is not public, AND

Visibility of the room is restricted OR the invitee is not a member of the workspace

We only comment in the room when we invite accounts who can't already join on their own free will (i.e. non workspace members in workspace visibility rooms)

Which case are you testing exactly?

Yeah the conditions seems correct, I tested with members outside workspace and the message is shown now.

eh2077 · 2025-08-11T14:12:17Z

@daledah Can you please update the PR? Then I can review it again so we can move it forward.

eh2077 · 2025-08-15T14:11:43Z

@daledah Friendly bump

daledah · 2025-08-18T02:27:05Z

@eh2077 Sorry for the delay, I updated!

eh2077 · 2025-08-19T15:34:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

eh2077

LGTM 🚀

OSBotify · 2025-08-20T19:17:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-08-22T17:57:57Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.1.98-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-08-26T10:59:01Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.98-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

daledah added 2 commits July 11, 2025 00:04

fix: unify invite message text

710bfcd

fix: test

2fec420

daledah marked this pull request as ready for review July 10, 2025 17:25

daledah requested a review from a team as a code owner July 10, 2025 17:25

melvin-bot Bot requested review from eh2077 and removed request for a team July 10, 2025 17:25

daledah mentioned this pull request Jul 10, 2025

[Due for payment 2025-09-02] [$250] Group - When inviting a new member, message on chat preview is different on LHN and "Search" #65314

Closed

8 tasks

eh2077 reviewed Jul 14, 2025

View reviewed changes

Merge branch 'main' into fix/65314

1a41ad9

daledah added 2 commits August 18, 2025 09:21

Merge branch 'main' into fix/65314

d33cd39

fix: make same changes for policy invite/remove action

8f717f2

eh2077 approved these changes Aug 20, 2025

View reviewed changes

melvin-bot Bot requested a review from aldo-expensify August 20, 2025 14:02

aldo-expensify approved these changes Aug 20, 2025

View reviewed changes

aldo-expensify merged commit 5f45065 into Expensify:main Aug 20, 2025
21 checks passed

OSBotify mentioned this pull request Aug 22, 2025

Deploy Checklist: New Expensify 2025-08-22 #69038

Closed

	ROOM_CHANGE_LOG: {
	INVITE_TO_ROOM: 'INVITETOROOM',
	REMOVE_FROM_ROOM: 'REMOVEFROMROOM',
	LEAVE_ROOM: 'LEAVEROOM',
	UPDATE_ROOM_DESCRIPTION: 'UPDATEROOMDESCRIPTION',
	},

Conversation

daledah commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daledah Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Aug 11, 2025

Uh oh!

eh2077 commented Aug 15, 2025

Uh oh!

daledah commented Aug 18, 2025

Uh oh!

eh2077 commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Aug 20, 2025

Uh oh!

OSBotify commented Aug 22, 2025

Uh oh!

OSBotify commented Aug 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daledah commented Jul 10, 2025 •

edited

Loading

daledah Jul 17, 2025 •

edited

Loading

eh2077 commented Aug 19, 2025 •

edited

Loading