Feature/kuba nowakowski/update the new report empty state by sumo-slonik · Pull Request #66057 · Expensify/App

sumo-slonik · 2025-07-14T14:10:37Z

Explanation of Change

Fixed Issues

$ #64730
$ #65830
PROPOSAL:

Tests

Create a new report.
Check if a dropdown appears under the "Empty state" text.
Click it and check if there are options for "Add Expense" and "Add Unreported Expense."
Add an expense.

Verify that no errors appear in the JS console

Offline tests

Unnesesary

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-06-27.at.19.17.38.mov

Android: mWeb Chrome

android.web.1.mov

iOS: Native

ios.native.mov

iOS: mWeb Safari

web.ios.mov

MacOS: Chrome / Safari

web.mac.mov

MacOS: Desktop

desktop.mov

…t-empty-state # Conflicts: # src/components/MoneyRequestReportView/SearchMoneyRequestReportEmptyState.tsx # src/libs/ReportSecondaryActionUtils.ts

melvin-bot · 2025-07-15T08:55:43Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…t-empty-state # Conflicts: # tests/unit/ReportPrimaryActionUtilsTest.ts

jjcoffee · 2025-07-16T14:40:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-app-2025-09-25_16.48.46.mp4

Android: mWeb Chrome

android-chrome-2025-09-25_16.52.55.mp4

iOS: HybridApp

ios-app-2025-09-25_16.29.04.mp4

iOS: mWeb Safari

ios-safari-2025-09-25_16.31.28.mp4

MacOS: Chrome / Safari

desktop-chrome-2025-09-25_14.46.20.mp4

MacOS: Desktop

desktop-app-2025-09-25_16.15.06.mp4

jjcoffee · 2025-07-16T14:44:06Z

@sumo-slonik Should we add a QA test for having workflows disabled?

jjcoffee · 2025-07-16T14:44:50Z

@sumo-slonik Also we should probably add #65830 to the linked issues list.

jjcoffee · 2025-07-16T14:56:09Z

With workflows disabled I get an error when creating an expense on an empty or an existing expense report:

sumo-slonik · 2025-07-16T14:56:33Z

@sumo-slonik Should we add a QA test for having workflows disabled?

I believe we can add it, though it didn’t seem strictly necessary to me since it was a bug that already existed in production, and this feature simply brought it to light. It has been addressed as part of this PR, but I didn’t treat it as its main focus. Let me know if you think it’s worth adding to the test steps, I can add it if so.

sumo-slonik · 2025-07-16T14:58:55Z

With workflows disabled I get an error when creating an expense on an empty or an existing expense report

This looks like a backend issue, I’ve also encountered these errors before, but I assumed it was just a temporary problem.

Co-authored-by: Joel Davies <joeld.dev@gmail.com>

sumo-slonik · 2025-07-16T15:01:33Z

There's also an issue with adding expenses here. The situation is slightly different, but the error on the frontend looks similar. I’ll check if applying these changes makes any difference:

sumo-slonik · 2025-07-16T15:09:19Z

There's also an issue with adding expenses here. The situation is slightly different, but the error on the frontend looks similar. I’ll check if applying these changes makes any difference:

The fix from the PR is not working for this issue. I will take a deeper look into the problem then.

sumo-slonik · 2025-07-18T13:38:14Z

Based on what I checked, it seems to be a backend issue. I looked into the data we're sending from the frontend, and it appears that on the backend side it's not possible to add a report when workflows are disabled. What seems most likely to me is that the issue is related to the workflow responsible for adding approvals.

jjcoffee · 2025-09-25T15:01:32Z

Otherwise tests well 👍

shawnborton · 2025-09-25T15:55:04Z

Good catch on that, let's make it look like staging 👍

mountiny · 2025-09-25T17:18:59Z

@sumo-slonik welcome back! Let's wrap this one up

sumo-slonik · 2025-09-26T09:06:59Z

I’m back from vacation and I’m getting to it now.

…t-empty-state

sumo-slonik · 2025-09-26T09:46:46Z

It seems to me that now it’s centered as it should be.

Screen.Recording.2025-09-26.at.11.40.44.mov

Apart from the centering, is there anything else we should fix here @jjcoffee?

codecov · 2025-09-26T09:49:17Z

Codecov Report

❌ Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...tReportView/SearchMoneyRequestReportEmptyState.tsx	0.00%	13 Missing ⚠️
src/components/EmptyStateComponent/index.tsx	75.00%	1 Missing ⚠️
...equestReportView/MoneyRequestReportActionsList.tsx	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

shawnborton · 2025-09-26T10:20:32Z

Can you show us what it looks like when the report has no expenses but has a comment?

sumo-slonik · 2025-09-26T10:24:39Z

After adding the comments, it looks like this:

Screen.Recording.2025-09-26.at.12.23.00.mov

jjcoffee · 2025-09-26T11:09:51Z

Sorry, one other thing I'm noticing now is that for a workspace with Workflows disabled, there are some "next steps" messages that disappear after a brief pause:

Waiting for you to add expenses
Waiting for your expenses to automatically submit (after creating an expense)

desktop-chrome-2025-09-26_13.04.23.mp4

jjcoffee · 2025-09-26T11:10:40Z

And just for completeness, here's what it looks like if you create an empty report and then delete the associated workspace:

sumo-slonik · 2025-09-26T12:19:17Z

And just for completeness, here's what it looks like if you create an empty report and then delete the associated workspace:

It seems to me that this is the expected behavior, because we don’t have the option to add expenses at that point, so the part responsible for adding them is hidden. But if I’m wrong, I’m happy to correct it as well.

sumo-slonik · 2025-09-26T12:30:18Z

Sorry, one other thing I'm noticing now is that for a workspace with Workflows disabled, there are some "next steps" messages that disappear after a brief pause:

Waiting for you to add expenses

Waiting for your expenses to automatically submit (after creating an expense)

desktop-chrome-2025-09-26_13.04.23.mp4

Screen.Recording.2025-09-26.at.14.28.14.mov

I’m already working on fixing this, as it’s related to the empty state. FYI, it also occurs on the staging environment.

jjcoffee · 2025-09-26T13:56:23Z

It seems to me that this is the expected behavior, because we don’t have the option to add expenses at that point, so the part responsible for adding them is hidden. But if I’m wrong, I’m happy to correct it as well.

Yeah it was more just to show what it looks like as it's a bit empty looking without a subtitle. @shawnborton Any thoughts on this? I guess it's not a super important screen anyway.

jjcoffee · 2025-09-26T13:56:50Z

I’m already working on fixing this, as it’s related to the empty state. FYI, it also occurs on the staging environment.

Maybe we can leave it for a followup if it's going to take long. cc @mountiny

sumo-slonik · 2025-09-26T14:12:02Z

I’m already working on fixing this, as it’s related to the empty state. FYI, it also occurs on the staging environment.

Maybe we can leave it for a followup if it's going to take long. cc @mountiny

The bug comes from the fact that in the optimistic data we create the contents of the next steps for this case, but we don’t receive them from the backend, so we overwrite them with an empty object.
My question is: do we want the next steps that show up and then disappear to remain, or do we want them not to appear at all from the beginning?
The first solution would require a small change in the value returned from the backend, while the second would require adjusting the generation of optimistic steps so that they match what the backend returns now.

shawnborton · 2025-09-26T15:05:31Z

I think it's fine, but it does reveal a bug that when there is no next steps, we need to fully hide the wrapper so that we don't get the extra gap here below the header info (notice how the padding below the avatar + text is bigger than above):

But yeah, seems unrelated to this PR maybe?

mountiny · 2025-09-26T17:42:16Z

@sumo-slonik @jjcoffee Yeah if this is reproducible in main, lets not fix it here as that will just add a scope to the PR that is already complex

Can you please report it in slack with the reproduction steps so QA can create a new issue for it?

sumo-slonik · 2025-09-29T07:58:13Z

@sumo-slonik @jjcoffee Yeah if this is reproducible in main, lets not fix it here as that will just add a scope to the PR that is already complex

Can you please report it in slack with the reproduction steps so QA can create a new issue for it?

https://swmansion.slack.com/archives/C049HHMV9SM/p1759132401737009

I wrote about it on Slack.

I think it's fine, but it does reveal a bug that when there is no next steps, we need to fully hide the wrapper so that we don't get the extra gap here below the header info (notice how the padding below the avatar + text is bigger than above):

But yeah, seems unrelated to this PR maybe?

I think we should do this in a separate PR, since it also affects STG. This PR is already quite complex even without it, I think we should aim to merge this PR so that its scope doesn’t grow any further.

jjcoffee

LGTM!

sumo-slonik · 2025-09-29T13:44:23Z

Here we have an issue with the optimistic next steps.

OSBotify · 2025-09-29T14:12:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-29T20:37:45Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.2.20-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-30T22:53:33Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.20-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

sumo-slonik added 10 commits July 14, 2025 10:57

working on IOU type fix

5bee8d0

Merge branch 'main' into feature/kuba-nowakowski/Update-the-new-repor…

a628522

…t-empty-state # Conflicts: # src/components/MoneyRequestReportView/SearchMoneyRequestReportEmptyState.tsx # src/libs/ReportSecondaryActionUtils.ts

revert the revert of empty state (without translations)

67b7c00

add translations

c9b7cdf

remove debuggers

b18bb0b

remove import arePaymentsEnabled

29e171b

add canAddOrDelete condition to empty report

19119c8

add missing comments

54b1bd3

fix import

b812d26

check if report is archived

69bdb0f

sumo-slonik marked this pull request as ready for review July 15, 2025 08:55

sumo-slonik requested a review from a team as a code owner July 15, 2025 08:55

melvin-bot Bot requested review from jjcoffee and removed request for a team July 15, 2025 08:55

mountiny assigned sumo-slonik Jul 15, 2025

sumo-slonik added 3 commits July 16, 2025 12:59

Merge branch 'main' into feature/kuba-nowakowski/Update-the-new-repor…

d2e5338

…t-empty-state # Conflicts: # tests/unit/ReportPrimaryActionUtilsTest.ts

fix tsx and unit

4fe59b0

add jest test

17a5c0f

jjcoffee reviewed Jul 16, 2025

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

change comment in new utils condition

77f4505

Co-authored-by: Joel Davies <joeld.dev@gmail.com>

sumo-slonik added 2 commits September 26, 2025 11:09

Merge branch 'main' into feature/kuba-nowakowski/Update-the-new-repor…

cd99604

…t-empty-state

fix centring of container

07f5b98

jjcoffee approved these changes Sep 29, 2025

View reviewed changes

melvin-bot Bot requested a review from marcochavezf September 29, 2025 08:27

marcochavezf approved these changes Sep 29, 2025

View reviewed changes

marcochavezf merged commit 556957f into Expensify:main Sep 29, 2025
21 checks passed

OSBotify mentioned this pull request Sep 29, 2025

Deploy Checklist: New Expensify 2025-09-29 #71500

Closed

69 tasks

melvin-bot Bot mentioned this pull request Sep 30, 2025

[Due for payment 2025-10-07] [$50] Expense - Add expense button is present when Workflows are disabled or workspace is deleted #65830

Closed

8 tasks

Conversation

sumo-slonik commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 15, 2025

Uh oh!

Uh oh!

jjcoffee commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Jul 16, 2025

Uh oh!

jjcoffee commented Jul 16, 2025

Uh oh!

jjcoffee commented Jul 16, 2025

Uh oh!

sumo-slonik commented Jul 16, 2025

Uh oh!

sumo-slonik commented Jul 16, 2025

Uh oh!

sumo-slonik commented Jul 16, 2025

Uh oh!

sumo-slonik commented Jul 16, 2025

Uh oh!

sumo-slonik commented Jul 18, 2025

Uh oh!

jjcoffee commented Sep 25, 2025

Uh oh!

shawnborton commented Sep 25, 2025

Uh oh!

mountiny commented Sep 25, 2025

Uh oh!

sumo-slonik commented Sep 26, 2025

Uh oh!

sumo-slonik commented Sep 26, 2025

Uh oh!

codecov Bot commented Sep 26, 2025

Codecov Report

Uh oh!

shawnborton commented Sep 26, 2025

Uh oh!

sumo-slonik commented Sep 26, 2025

Uh oh!

jjcoffee commented Sep 26, 2025

Uh oh!

jjcoffee commented Sep 26, 2025

Uh oh!

sumo-slonik commented Sep 26, 2025

Uh oh!

sumo-slonik commented Sep 26, 2025

Uh oh!

jjcoffee commented Sep 26, 2025

Uh oh!

jjcoffee commented Sep 26, 2025

Uh oh!

sumo-slonik commented Sep 26, 2025

Uh oh!

shawnborton commented Sep 26, 2025

Uh oh!

mountiny commented Sep 26, 2025

Uh oh!

sumo-slonik commented Sep 29, 2025

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

sumo-slonik commented Sep 29, 2025

Uh oh!

Uh oh!

OSBotify commented Sep 29, 2025

Uh oh!

sumo-slonik commented Jul 14, 2025 •

edited

Loading

jjcoffee commented Jul 16, 2025 •

edited

Loading