Skip to content

Migrate PaymentCardCurrencyModal to use Reanimated modal #66146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 6 commits into from
Jul 22, 2025
Merged

Migrate PaymentCardCurrencyModal to use Reanimated modal #66146

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ebc212
Change currency modal to reanimated
OlGierd03 Jul 15, 2025
b2e9bd7
Merge branch 'main' into @OlGierd03/reanimated-currency-modal
OlGierd03 Jul 16, 2025
55c19a7
Merge branch 'main' into @OlGierd03/reanimated-currency-modal
OlGierd03 Jul 16, 2025
a9df595
Remove redundant lines
OlGierd03 Jul 16, 2025
6ec97d9
Bring back onBackdropPress and remove unused props
blazejkustra Jul 17, 2025
942088e
Merge branch 'main' into @OlGierd03/reanimated-currency-modal
OlGierd03 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/components/AddPaymentCard/PaymentCardCurrencyModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import ScreenWrapper from '@components/ScreenWrapper';
import SelectionList from '@components/SelectionList';
import RadioListItem from '@components/SelectionList/RadioListItem';
import useLocalize from '@hooks/useLocalize';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useThemeStyles from '@hooks/useThemeStyles';
import Navigation from '@libs/Navigation/Navigation';
import CONST from '@src/CONST';
Expand All @@ -29,7 +28,6 @@ type PaymentCardCurrencyModalProps = {
};

function PaymentCardCurrencyModal({isVisible, currencies, currentCurrency = CONST.PAYMENT_CARD_CURRENCY.USD, onCurrencyChange, onClose}: PaymentCardCurrencyModalProps) {
const {shouldUseNarrowLayout} = useResponsiveLayout();
const styles = useThemeStyles();
const {translate} = useLocalize();
const {sections} = useMemo(
Expand All @@ -54,10 +52,11 @@ function PaymentCardCurrencyModal({isVisible, currencies, currentCurrency = CONS
isVisible={isVisible}
onClose={() => onClose?.()}
onModalHide={onClose}
hideModalContentWhileAnimating
innerContainerStyle={styles.RHPNavigatorContainer(shouldUseNarrowLayout)}
onBackdropPress={Navigation.dismissModal}
useNativeDriver
onBackdropPress={() => {
onClose?.();

@mountiny mountiny Jul 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this param need to be optional? We could make it required to avoid the optional chaining here

@ZhenjaHorbach ZhenjaHorbach Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I remember it is a prop from a parent component
So I think it's appropriate here

Navigation.dismissModal();
}}
shouldUseReanimatedModal
>
<ScreenWrapper
style={styles.pb0}
Expand Down
Loading