replace the space at the beginning of each line with nbsp by nkdengineer · Pull Request #66686 · Expensify/App

nkdengineer · 2025-07-18T03:20:06Z

Explanation of Change

This PR fixes the extra space between lines when pasting code.

Fixed Issues

Tests

Copy the text

 if (files.length > 0) { 
     // Prevent the default so we do not post the file name into the text box 
     event.preventDefault(); 
     this.props.onPasteFile(event.clipboardData.files[0]); 
     return;

Navigate to the Expensify app
Paste the code into the compose box in a conversation
For iOS native: an empty line is added, it's the same as Slack
For other platforms: the pasted code should retain original formatting:

No extra space between lines.
All lines left-aligned as in the source code.
Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-07-18T03:20:58Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2025-07-18T03:22:39Z

@ZhenjaHorbach I checked the behavior on Slack again and it just replace the space at the beginning of each line with &nbsp so I updated the PR to do that. And for the issues mention in #65143, I also can reproduce on staging

nkdengineer · 2025-07-22T02:38:38Z

friendly bump @ZhenjaHorbach

nkdengineer · 2025-07-28T04:57:13Z

bump @ZhenjaHorbach

ZhenjaHorbach · 2025-07-31T09:48:47Z

Sorry for delay
I will try to find all potential issues which were mentioned in slack today or tomorrow

nkdengineer · 2025-08-06T03:02:18Z

kindly bump @ZhenjaHorbach

ZhenjaHorbach · 2025-08-11T15:44:09Z

Sorry for delay
Here are all the issues that I found in the bug channel which may be related with these changes
And we need to recheck this cases and make sure that is not our issues

1.

BUG: Seems we have a regression in markdown rendering - we are splitting words and breaking to a new line unnecessarily after a link. To reproduce, send a message in chat that has a link then resize the window and watch the words and lines break strangely. Found in desktop staging v9.1.72-0. Applause, can you please ensure a regression test gets added for this after it is fixed?

2.

BUG: Seems like on staging web I am seeing words break and not wrap correctly. Example in screenshot shows you wrapped to yo u and y ou

3.

BUG: Something is messed up in the rendering engine. It's cutting words off in the middle. Additionally, hyphenated words break lines unnecessarily, but only when apparently preceded by a bold word, and followed by a lot of text? I got it to break with:
bold text hyphenated-word case (asdf as asdfas asdf asdf asdf asdfas dfasd fasdf asdf asdf asdf asdf asfd asdf adf asdfas dfasdf asdfas dfasfd a sdfas fdasfd asdf asdfa)
But not with:
bold text hyphenated-word case (asdf as asdfas asdf asdf asdf asdfas dfasd fasdf asdf asdf asdf asdf asfd asdf adf asdfas dfasdf asdfas dfasfd a)

nkdengineer · 2025-08-13T02:43:40Z

will take a look today

nkdengineer · 2025-08-14T04:38:44Z

@ZhenjaHorbach Sorry I can't access to these links you provided.

The first issue: it also happens on staging (I posed the evidence in the OP [Due for payment 2025-09-17] [$250] Chat - Formatting is incorrect when pasting code into the compose box #62848 (comment))
The second and third issues: can you please give me the text to test?

nkdengineer · 2025-08-14T04:42:40Z

In case it happens on staging, I don't think we should fix it here

ZhenjaHorbach · 2025-08-18T15:58:38Z

@ZhenjaHorbach Sorry I can't access to these links you provided.

The first issue: it also happens on staging (I posed the evidence in the OP [$250] Chat - Formatting is incorrect when pasting code into the compose box #62848 (comment))

The second and third issues: can you please give me the text to test?

Unfortunately I don't have texts
Since all the screenshots and descriptions are from bug reports

nkdengineer · 2025-08-19T02:39:21Z

I can't reproduce case 2 and 3 on main and my PR

Screen.Recording.2025-08-19.at.09.37.32.mp4

ZhenjaHorbach · 2025-08-20T12:30:53Z

Hmmm
Yeah
Maybe this has all been fixed already
Okay
I'll try to test again
And if I don't find anything
We'll merge the current version !

ZhenjaHorbach · 2025-08-22T09:24:09Z

Okay
Also works good to me

ZhenjaHorbach · 2025-08-22T09:24:27Z

@nkdengineer
Could you update a branch to the latest version of main ?

ZhenjaHorbach · 2025-08-22T09:24:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

nkdengineer · 2025-08-28T02:38:39Z

@ZhenjaHorbach any updates?

ZhenjaHorbach · 2025-09-02T14:58:06Z

Okay
Everything works good me
I hope there won't be any issues this time
LGTM !

nkdengineer · 2025-09-08T01:58:50Z

@MonilBhavsar kindly bump

OSBotify · 2025-09-08T06:46:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-09T03:26:25Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.3-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-09T18:18:11Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.5-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-09-09T21:20:09Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.8-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-10T22:58:03Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.8-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

replace the space at the beginning of each line with nbsp

2d80e39

nkdengineer marked this pull request as ready for review July 18, 2025 03:20

nkdengineer requested a review from a team as a code owner July 18, 2025 03:20

melvin-bot Bot requested a review from ZhenjaHorbach July 18, 2025 03:20

melvin-bot Bot removed the request for review from a team July 18, 2025 03:20

update type

47f2190

Merge branch 'main' into fix/62848-replace-space-at-the-beginning

1f7cde3

Merge branch 'main' into fix/62848-replace-space-at-the-beginning

3f7c24c

Merge branch 'main' into fix/62848-replace-space-at-the-beginning

6891534

ZhenjaHorbach approved these changes Sep 2, 2025

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar September 2, 2025 14:58

MonilBhavsar approved these changes Sep 8, 2025

View reviewed changes

MonilBhavsar merged commit a3f8cbc into Expensify:main Sep 8, 2025
21 checks passed

OSBotify mentioned this pull request Sep 9, 2025

Deploy Checklist: New Expensify 2025-09-09 #70157

Closed

83 tasks

jponikarchuk mentioned this pull request Sep 9, 2025

Chat - Difference in format of preview text and sent message. #70166

Closed

8 tasks

melvin-bot Bot mentioned this pull request Sep 10, 2025

[Due for payment 2025-09-17] [$250] Chat - Formatting is incorrect when pasting code into the compose box #62848

Closed

8 tasks

Conversation

nkdengineer commented Jul 18, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 18, 2025

Uh oh!

nkdengineer commented Jul 18, 2025

Uh oh!

nkdengineer commented Jul 22, 2025

Uh oh!

nkdengineer commented Jul 28, 2025

Uh oh!

ZhenjaHorbach commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Aug 6, 2025

Uh oh!

ZhenjaHorbach commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Aug 13, 2025

Uh oh!

nkdengineer commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Aug 14, 2025

Uh oh!

ZhenjaHorbach commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Aug 19, 2025

Uh oh!

ZhenjaHorbach commented Aug 20, 2025

Uh oh!

ZhenjaHorbach commented Aug 22, 2025

Uh oh!

ZhenjaHorbach commented Aug 22, 2025

Uh oh!

ZhenjaHorbach commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

nkdengineer commented Aug 28, 2025

Uh oh!

ZhenjaHorbach commented Sep 2, 2025

Uh oh!

nkdengineer commented Sep 8, 2025

Uh oh!

Uh oh!

OSBotify commented Sep 8, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ZhenjaHorbach commented Jul 31, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 11, 2025 •

edited

Loading

nkdengineer commented Aug 14, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 18, 2025 •

edited

Loading

ZhenjaHorbach commented Aug 22, 2025 •

edited

Loading