Optimize ShareTab component by implementing same optimizations as in SearchAutocompleteList by sosek108 · Pull Request #66965 · Expensify/App

sosek108 · 2025-07-23T14:25:21Z

Explanation of Change

This change continues the SearchAutocompleteList performance optimization (#65810) by applying the same pattern to the ShareTab component. Instead of using a two-step process (get all options, then filter), it moves the filtering logic directly into the getSearchOptions call with search parameters (textInputValue, limit of 20, filtering enabled). This eliminates the useFastSearchFromOptions hook dependency and reduces computational overhead by avoiding intermediate data structure creation. The optimization maintains all existing functionality while providing the same performance benefits as the SearchAutocompleteList component.

Fixed Issues

$ #66615
PROPOSAL: #66615

Tests

Open gallery or Files application on the phone
Select any photo
Click Share
From options select Expensify app
Verify if list of recent chats is visible
Confirm that initial Recent chats are presented in right order
1. open second chat on the list
2. write any comment
3. open search again and verify if order of reports has changed
type partial name of any of reports (eg alfa)
1. confirm that only reports that match query are presented
2. repeat with query made of 2 words (eg alfa beta)
type partial name of any user
1. confirm that only persons that match query are presented
2. repeat with query made of 2 words

Offline tests

N/A

QA Steps

Open gallery or Files application on the phone
Select any photo
Click Share
From options select Expensify app
Verify if list of recent chats is visible
Confirm that initial Recent chats are presented in right order
1. open second chat on the list
2. write any comment
3. open search again and verify if order of reports has changed
type partial name of any of reports (eg alfa)
1. confirm that only reports that match query are presented
2. repeat with query made of 2 words (eg alfa beta)
type partial name of any user
1. confirm that only persons that match query are presented
2. repeat with query made of 2 words

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

Moj.film.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

kacper-mikolajczak · 2025-07-28T14:22:45Z

Hi @mountiny! I am filling in for @sosek108 for this PR as well. Hubert mentioned that we can undraft this PR when #65810 is merged (which was done recently ✅).

However, I am not able to undraft the PR - could you help me out a little with your super-powers? Thanks! ❤️

melvin-bot · 2025-07-28T17:38:01Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-07-28T17:38:21Z

@kacper-mikolajczak Made it ready for a review, though can you sync with main and also lets wait for the pr to hit staging and not be reverted 😄

kacper-mikolajczak · 2025-07-29T08:41:57Z

PR prepared for review ✅ @mountiny

kacper-mikolajczak · 2025-07-29T11:01:44Z

@roryabraham Seems like this PR could also be related to changes there: #67073 (review)

getusha · 2025-07-29T15:02:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-rec-15.webm

iOS: HybridApp

simulator-screen-recording-iphone-15-pro-2025-08-05-at-164535_ujoDXw9C.mp4

getusha · 2025-07-29T16:12:28Z

Lets remove 9&10 from tests

roryabraham · 2025-07-29T19:17:12Z

Yeah, there's definitely overlap between this PR and #67073 (review). Let's put both on HOLD until @sosek108 is back

mountiny · 2025-07-29T19:23:06Z

@roryabraham I think we do not have to wait since @kacper-mikolajczak has taken over his work intentionally when @sosek108 is ooo

roryabraham · 2025-07-29T19:36:06Z

@mountiny see convo in the other PR

mountiny · 2025-07-29T19:45:36Z

Ah I see, thanks! Makes sense, would love to get the PR size to much more manageable state!

roryabraham · 2025-07-29T20:31:04Z

It's not the size that really tripped me up - but the lack of screenshots and benchmarks. The size made the code harder to review, but wasn't really a blocker

mountiny · 2025-07-29T20:53:46Z

Yep, all those points are valid, we still expect even from the expert contributors @kacper-mikolajczak @sosek108 to complete the checklist fully with recordings too. Exceptions can be made.

For performance PRs, always make sure to link the results, too, please. Usually you have those in the proposal already but in case of this pr, it changes up a loot since the proposal so fresh measurements are welcomed

sosek108 · 2025-08-04T13:19:04Z

I think that we can unhold this PR as I am back. In previous comment I've posted benchmark for ShareTab that shows visible upgrade on component load time.

mountiny · 2025-08-04T16:34:14Z

Is the ShareTab not available on Android? Now I am not sure

getusha · 2025-08-04T16:39:09Z

Is the ShareTab not available on Android? Now I am not sure

It's available

mountiny · 2025-08-04T18:51:07Z

@sosek108 Can you please include the android testing videos too? Thanks! Keep in mind to include it for all platforms where applicable on all PRs unless otherwise specified

roryabraham · 2025-08-04T22:52:38Z

@sosek108 if this is ready for review, feel free to remove [HOLD] from the title

roryabraham · 2025-08-04T22:52:59Z

I see you mentioned it's ready to come off hold, so I'll just go for it

sosek108 · 2025-08-05T06:39:34Z

Here is video for Android. Right is new version:/

android.mp4

getusha

Tests well!

roryabraham · 2025-08-05T17:00:31Z

+ * @returns True if all search terms are found in the search text
+ */
+function doSearchTermsMatch(searchTerms: string[], searchText: string): boolean {
+    return searchTerms.length > 0 ? searchTerms.every((term) => searchText.includes(term)) : true;


NAB but this ternary is unnecessary. You can just do this:

Suggested change

return searchTerms.length > 0 ? searchTerms.every((term) => searchText.includes(term)) : true;

return searchTerms.every((term) => searchText.includes(term));

If searchTerms is an empty array, it will return true

and in that case, I think you could just remove the named doSearchTermsMatch function and inline that simple statement 🤷🏼

Yeah that would be a good clean up but NAB

Thanks, good catch!

mountiny

Looks good to me, just some follow up questions

mountiny · 2025-08-05T20:22:50Z

+ * @returns True if all search terms are found in the search text
+ */
+function doSearchTermsMatch(searchTerms: string[], searchText: string): boolean {
+    return searchTerms.length > 0 ? searchTerms.every((term) => searchText.includes(term)) : true;


Yeah that would be a good clean up but NAB

mountiny · 2025-08-05T20:27:34Z

                searchText += report.subtitle ?? '';
            } else if (report.isPolicyExpenseChat) {
-                searchText += `${report.subtitle ?? ''}${report.policyName ?? ''}`;
+                searchText += `${report.subtitle ?? ''}${report.item.policyName ?? ''}`;


I find it confusing why we sometimes access it directly and in this case through item

Probably autofill mistake. Fixed

roryabraham · 2025-08-05T20:35:30Z

We have conflicts here now, so please address the small cleanup items when you resolve conflicts then we can merge this. Thanks!

sosek108 · 2025-08-06T09:24:40Z

I've resolved merge conflict and applied cleaning fixes pointed out by @roryabraham and @mountiny (thanks for them!).

Now I see that Check unused styles check fails but I don't think it's caused by my changes 🔍👀

mountiny

Seems like there were few things leftover

sosek108 · 2025-08-07T07:55:51Z

@mountiny I've removed one leftover comment and answered your other comments.

All checks are passing now 🎉.

mountiny

Rory already approved and now there are no checks failing or no conflicts so I will merge this

OSBotify · 2025-08-07T09:16:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-08T02:28:27Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.91-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-12T04:07:48Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.92-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

sosek108 added 2 commits July 22, 2025 14:13

ShareTab optimization same as in SearchAutocompleteList

8fa03de

Merge branch 'perf/search-optimization' into perf/share-tab-optimization

97da756

sosek108 mentioned this pull request Jul 23, 2025

[Due for payment 2025-10-15] [$875] Optimize SearchRouter via SearchAutocompleteList initial render performance through early data filtering and ordering #66615

Closed

sosek108 added 3 commits July 24, 2025 09:49

Merge branch 'perf/search-optimization' into perf/share-tab-optimization

d86a8aa

Remove FastSearch from codebase.

f4e0cae

prettier fixes

50e914a

sosek108 changed the title ~~Perf/share tab optimization~~ Optimize ShareTab component by implementing same optimizations as in SearchAutocompleteList Jul 24, 2025

mountiny marked this pull request as ready for review July 28, 2025 17:37

mountiny requested a review from a team as a code owner July 28, 2025 17:37

melvin-bot Bot requested review from getusha and removed request for a team July 28, 2025 17:38

Merge branch 'main' into perf/share-tab-optimization

76e3ae0

mountiny assigned sosek108 and kacper-mikolajczak Jul 29, 2025

roryabraham changed the title ~~Optimize ShareTab component by implementing same optimizations as in SearchAutocompleteList~~ [HOLD] Optimize ShareTab component by implementing same optimizations as in SearchAutocompleteList Jul 29, 2025

sosek108 mentioned this pull request Aug 4, 2025

Optimize OptionData object for search contexts #67073

Merged

48 tasks

Merge branch 'main' into perf/share-tab-optimization

83f725a

roryabraham changed the title ~~[HOLD] Optimize ShareTab component by implementing same optimizations as in SearchAutocompleteList~~ Optimize ShareTab component by implementing same optimizations as in SearchAutocompleteList Aug 4, 2025

getusha approved these changes Aug 5, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny August 5, 2025 14:13

roryabraham previously approved these changes Aug 5, 2025

View reviewed changes

roryabraham reviewed Aug 5, 2025

View reviewed changes

mountiny previously approved these changes Aug 5, 2025

View reviewed changes

sosek108 added 3 commits August 6, 2025 10:49

Merge branch 'main' into perf/share-tab-optimization

e61d4eb

Cleaning in isValidReport and getValidReports

c476f28

doSearchTerms - cleaning up

08484cc

sosek108 dismissed stale reviews from mountiny and roryabraham via 08484cc August 6, 2025 09:19

mountiny requested changes Aug 6, 2025

View reviewed changes

Comment thread src/libs/OptionsListUtils.ts

Comment thread src/libs/OptionsListUtils.ts

Comment thread src/libs/OptionsListUtils.ts Outdated

sosek108 added 2 commits August 7, 2025 09:29

Merge branch 'main' into perf/share-tab-optimization

3c03f06

Remove leftover comment

ea849de

mountiny approved these changes Aug 7, 2025

View reviewed changes

mountiny merged commit 91b52b0 into Expensify:main Aug 7, 2025
21 checks passed

github-actions Bot mentioned this pull request Aug 8, 2025

Deploy Checklist: New Expensify 2025-08-08 #68168

Closed

75 tasks

	return searchTerms.length > 0 ? searchTerms.every((term) => searchText.includes(term)) : true;
	return searchTerms.every((term) => searchText.includes(term));

Conversation

sosek108 commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

kacper-mikolajczak commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Jul 28, 2025

Uh oh!

mountiny commented Jul 28, 2025

Uh oh!

kacper-mikolajczak commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kacper-mikolajczak commented Jul 29, 2025

Uh oh!

getusha commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha commented Jul 29, 2025

Uh oh!

roryabraham commented Jul 29, 2025

Uh oh!

mountiny commented Jul 29, 2025

Uh oh!

roryabraham commented Jul 29, 2025

Uh oh!

mountiny commented Jul 29, 2025

Uh oh!

roryabraham commented Jul 29, 2025

Uh oh!

mountiny commented Jul 29, 2025

Uh oh!

sosek108 commented Aug 4, 2025

Uh oh!

mountiny commented Aug 4, 2025

Uh oh!

getusha commented Aug 4, 2025

Uh oh!

mountiny commented Aug 4, 2025

Uh oh!

roryabraham commented Aug 4, 2025

Uh oh!

roryabraham commented Aug 4, 2025

Uh oh!

sosek108 commented Aug 5, 2025

Uh oh!

getusha left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

roryabraham Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

sosek108 Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny Aug 5, 2025

Choose a reason for hiding this comment

sosek108 commented Jul 23, 2025 •

edited

Loading

kacper-mikolajczak commented Jul 28, 2025 •

edited

Loading

kacper-mikolajczak commented Jul 29, 2025 •

edited

Loading

getusha commented Jul 29, 2025 •

edited

Loading