fix: Android - Search - Keyboard is not automatically opened despite input being focused. by Krishna2323 · Pull Request #67297 · Expensify/App

Krishna2323 · 2025-07-29T07:38:21Z

Explanation of Change

Fixed Issues

$ #65855
PROPOSAL: #65855 (comment)

Tests

Open the app
Tap on the search icon on the top right corner.
Verify that input is focused and keyboard is automatically opened.
Return to "Inbox" and tap on the search icon again.
Verify that input is focused and keyboard is automatically opened.

Verify that no errors appear in the JS console

Offline tests

Open the app
Tap on the search icon on the top right corner.
Verify that input is focused and keyboard is automatically opened.
Return to "Inbox" and tap on the search icon again.
Verify that input is focused and keyboard is automatically opened.

QA Steps

Open the app
Tap on the search icon on the top right corner.
Verify that input is focused and keyboard is automatically opened.
Return to "Inbox" and tap on the search icon again.
Verify that input is focused and keyboard is automatically opened.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…input being focused. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-07-29T07:38:25Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-07-29T08:21:11Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-07-30T05:54:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-05.at.9.53.38.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-08-05.at.9.52.06.AM.mov

iOS: HybridApp

Screen.Recording.2025-08-05.at.9.52.32.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-08-05.at.9.53.17.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-30.at.12.34.37.PM.mov

Screen.Recording.2025-08-05.at.9.46.53.AM.mov

MacOS: Desktop

Screen.Recording.2025-07-30.at.12.34.53.PM.mov

allgandalf · 2025-07-30T07:08:55Z

@@ -1,3 +1,4 @@
+import {useFocusEffect} from '@react-navigation/native';


@Krishna2323 if the original bug was only occurring on native platforms, why do we need to update the non native part ?

I believe we should be consistent with the focus delay across all platforms, which is why I also added the changes for non‑native platforms. The same approach was taken in the selection list, we didn’t only add the delay for native platforms but for all. Let me know if you think we should remove the non‑native input delay.

yeah i mean, why are we adding code to fix a problem if it doesn't exist in the first place

@amyevans interested in hearing what you think

Let's focus on fixing the problem experienced and only add the delay for native, where it is actually needed

@allgandalf I have updated the non-native file. Please check.

allgandalf · 2025-07-30T07:09:06Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

Please address this comment as well

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

allgandalf · 2025-07-31T08:33:48Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

Please address this comment as well

bump on above, do we need any action here?

Krishna2323 · 2025-07-31T08:38:27Z

bump on above, do we need any action here?

No action required.

allgandalf · 2025-07-31T09:09:53Z

    // Height fix is needed only for Text single line inputs
    const shouldApplyHeight = !shouldUseFullInputHeight && !isMultiline && !isMarkdownEnabled;

+    useFocusEffect(


I would highly appreciate if you can put a comment explaining why we added this effect and also link the original issue in the comment for easy reference to future folks wanting to understand the change

comment added.

#64968 looks like an incorrect issue link

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

allgandalf · 2025-08-01T06:30:21Z

    // Height fix is needed only for Text single line inputs
    const shouldApplyHeight = !shouldUseFullInputHeight && !isMultiline && !isMarkdownEnabled;

+    /** Focuses the text input when the component mounts, with a delay to allow navigation/modal animations to complete. */


@Krishna2323 please add the reason as to why we added this and not what it does, also please link up to the original issue for which we used the useFocusEffect

with a delay to allow navigation/modal animations to complete

This already defines why we need this, I have added the issue reference. If you still think something is missing, please tell me and I'll update.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

allgandalf · 2025-08-03T13:09:50Z

    // Height fix is needed only for Text single line inputs
    const shouldApplyHeight = !shouldUseFullInputHeight && !isMultiline && !isMarkdownEnabled;

+    /** Focuses the text input when the component mounts, with a delay to allow navigation/modal animations to complete. */


Suggested change

/** Focuses the text input when the component mounts, with a delay to allow navigation/modal animations to complete. */

/** We added a delay to focus on text input to allow navigation/modal animations to get completed, see issue https://github.com/Expensify/App/issues/64968 for more details */

comment updated.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

amyevans · 2025-08-06T18:37:09Z

    // Height fix is needed only for Text single line inputs
    const shouldApplyHeight = !shouldUseFullInputHeight && !isMultiline && !isMarkdownEnabled;

+    useFocusEffect(


#64968 looks like an incorrect issue link

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-08-07T05:03:57Z

@amyevans issue link updated.

amyevans

Thanks!

OSBotify · 2025-08-07T13:53:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-08T02:28:33Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.1.91-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-12T04:07:54Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.92-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

fix: Android - Search - Keyboard is not automatically opened despite …

818bc44

…input being focused. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review July 29, 2025 08:21

Krishna2323 requested a review from a team as a code owner July 29, 2025 08:21

melvin-bot Bot requested review from allgandalf and removed request for a team July 29, 2025 08:21

Krishna2323 mentioned this pull request Jul 29, 2025

[Due for payment 2025-10-27] [Due for payment 2025-08-20] [$250] Android - Search - Keyboard is not automatically opened despite input being focused. #65855

Closed

8 tasks

Merge branch 'Expensify:main' into krishna2323/issue/65855

a3d9d41

allgandalf reviewed Jul 30, 2025

View reviewed changes

Krishna2323 added 2 commits July 31, 2025 13:04

remove input focus delay from web file.

5cad5c8

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/65855

fcce1d7

allgandalf reviewed Jul 31, 2025

View reviewed changes

add comment.

f9b9ac2

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

allgandalf reviewed Aug 1, 2025

View reviewed changes

add issue reference.

292afe0

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

allgandalf reviewed Aug 3, 2025

View reviewed changes

Comment thread src/components/TextInput/BaseTextInput/implementation/index.native.tsx Outdated

update comment.

baa91c9

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

allgandalf approved these changes Aug 5, 2025

View reviewed changes

melvin-bot Bot requested a review from amyevans August 5, 2025 04:24

amyevans requested changes Aug 6, 2025

View reviewed changes

minor fix.

0e63056

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

allgandalf approved these changes Aug 7, 2025

View reviewed changes

melvin-bot Bot requested a review from amyevans August 7, 2025 06:05

amyevans approved these changes Aug 7, 2025

View reviewed changes

amyevans merged commit b6ea9a1 into Expensify:main Aug 7, 2025
20 checks passed

github-actions Bot mentioned this pull request Aug 8, 2025

Deploy Checklist: New Expensify 2025-08-08 #68168

Closed

75 tasks

linhvovan29546 mentioned this pull request Aug 8, 2025

[Due for payment 2025-08-20] [Due for payment 2025-08-19] Android - Chat - App crashes when opening emoji picker. #68186

Closed

8 tasks

		@@ -1,3 +1,4 @@
		import {useFocusEffect} from '@react-navigation/native';

	/** Focuses the text input when the component mounts, with a delay to allow navigation/modal animations to complete. */
	/** We added a delay to focus on text input to allow navigation/modal animations to get completed, see issue https://github.com/Expensify/App/issues/64968 for more details */

Conversation

Krishna2323 commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 29, 2025

Uh oh!

melvin-bot Bot commented Jul 29, 2025

Uh oh!

allgandalf commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Jul 30, 2025

Uh oh!

allgandalf commented Jul 31, 2025

Uh oh!

Krishna2323 commented Jul 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Aug 7, 2025

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Aug 7, 2025

Uh oh!

github-actions Bot commented Aug 8, 2025

Uh oh!

github-actions Bot commented Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented Jul 29, 2025 •

edited

Loading

allgandalf commented Jul 30, 2025 •

edited

Loading