Make Policy Rooms available in Search and LHN#6737
Merged
Conversation
added 17 commits
December 13, 2021 12:25
TomatoToaster
changed the title
jasperhuangg
approved these changes
Jan 5, 2022
jasperhuangg
left a comment
jasperhuangg
left a comment
Contributor
There was a problem hiding this comment.
Nice naming choices! Also, tested and works great :)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
21 tasks
Contributor
|
🚀 Deployed to staging by @yuwenmemon in version: 1.1.25-2 🚀
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joelbettner, please review when you get the chance
CC: @jasperhuangg @yuwenmemon
Details
Adds the rest of the UI for policyRooms so that we can see it in the header. This PR does not include the Report Details that'll be in a separate PR.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/176851
Tests
QA Steps
Verify that now when a policy room is created, we can see it in the LHN and in search.
Make sure you have a workspace already, then click on + in bottom left and choose New Room
Name it something and select your workspace
After it's created verify you see this:
Verify the report details look like this:
(Another PR is changing this so it might look different)
Send a message in the room and verify it works.
Verify that you can search for the room.
Tested On
Screenshots
Web