Skip to content

[NoQA] Replaced Onyx.connect with Onyx.connectWithoutView in e2eLogin #67539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldoglas merged 4 commits into from
Aug 4, 2025
Merged

[NoQA] Replaced Onyx.connect with Onyx.connectWithoutView in e2eLogin #67539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fac5173
Replaced Onyx.connect with Onyx.connectWithoutView in e2eLogin
shubham1206agra Jul 31, 2025
9fcdf67
Merge branch 'main' into refactor-onyx-23
shubham1206agra Aug 1, 2025
c319bdb
Apply suggestions from code review
shubham1206agra Aug 1, 2025
bf20bbd
Merge branch 'main' into refactor-onyx-23
shubham1206agra Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
"perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
"typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=319 --cache --cache-location=node_modules/.cache/eslint",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=316 --cache --cache-location=node_modules/.cache/eslint",
"lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
"lint-watch": "npx eslint-watch --watch --changed",
"shellcheck": "./scripts/shellCheck.sh",
Expand Down
6 changes: 4 additions & 2 deletions src/libs/E2E/actions/e2eLogin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ const e2eUserCredentials = {
export default function (): Promise<boolean> {
const waitForBeginSignInToFinish = (): Promise<void> =>
new Promise((resolve) => {
const id = Onyx.connect({
// We opted for `connectWithoutView` here as this is being used for mocking data for E2E flow.
const id = Onyx.connectWithoutView({
Comment thread
shubham1206agra marked this conversation as resolved.
key: ONYXKEYS.CREDENTIALS,
callback: (credentials) => {
// beginSignUp writes to credentials.login once the API call is complete
Expand All @@ -43,7 +44,8 @@ export default function (): Promise<boolean> {

// Subscribe to auth token, to check if we are authenticated
return new Promise((resolve, reject) => {
const connection = Onyx.connect({
// We opted for `connectWithoutView` here as this is being used for mocking data for E2E flow.
const connection = Onyx.connectWithoutView({
Comment thread
shubham1206agra marked this conversation as resolved.
key: ONYXKEYS.SESSION,
callback: (session) => {
if (session?.authToken == null || session.authToken.length === 0) {
Expand Down
Loading