Skip to content

[No QA] Update copy for deleting a workspace#6765

Merged
luacmartins merged 3 commits into
mainfrom
jack-updateCopy
Dec 16, 2021
Merged

[No QA] Update copy for deleting a workspace#6765
luacmartins merged 3 commits into
mainfrom
jack-updateCopy

Conversation

@thienlnam

@thienlnam thienlnam commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

Details

Fixed Issues

$ #6722

Tests

  1. Create a workspace
  2. Make sure the request to delete the workspace fails by disabling wifi or something similar
  3. Make sure you see the failure growl

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@thienlnam thienlnam requested a review from a team as a code owner December 15, 2021 00:38
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team December 15, 2021 00:38
Comment thread src/languages/es.js Outdated
jasperhuangg
jasperhuangg previously approved these changes Dec 16, 2021

@jasperhuangg jasperhuangg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus the comment from @luacmartins

@thienlnam

Copy link
Copy Markdown
Contributor Author

periodt removed

@luacmartins luacmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luacmartins luacmartins merged commit 736de1a into main Dec 16, 2021
@luacmartins luacmartins deleted the jack-updateCopy branch December 16, 2021 19:26
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@thienlnam thienlnam changed the title Update copy for deleting a workspace [No QA] Update copy for deleting a workspace Dec 16, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.21-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants