Skip to content

fix: search can be opened via CMD+K during What features are you interested in step #67804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 1 commit into from
Aug 7, 2025
Merged

fix: search can be opened via CMD+K during What features are you interested in step #67804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/SCREENS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,6 @@ const SCREENS = {
SCHEDULE_CALL: 'ScheduleCall',
},
PUBLIC_CONSOLE_DEBUG: 'Console_Debug',
ONBOARDING_MODAL: {
ONBOARDING: 'Onboarding',
},
SIGN_IN_WITH_APPLE_DESKTOP: 'AppleSignInDesktop',
SIGN_IN_WITH_GOOGLE_DESKTOP: 'GoogleSignInDesktop',
DESKTOP_SIGN_IN_REDIRECT: 'DesktopSignInRedirect',
Expand Down
18 changes: 1 addition & 17 deletions src/libs/Navigation/helpers/isNavigatorName.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,9 @@ import type {FullScreenName, OnboardingFlowName, SplitNavigatorName, SplitNaviga
import NAVIGATORS from '@src/NAVIGATORS';
import SCREENS from '@src/SCREENS';

const ONBOARDING_SCREENS = [
SCREENS.ONBOARDING.PERSONAL_DETAILS,
SCREENS.ONBOARDING.PURPOSE,
SCREENS.ONBOARDING_MODAL.ONBOARDING,
SCREENS.ONBOARDING.EMPLOYEES,
SCREENS.ONBOARDING.ACCOUNTING,
SCREENS.ONBOARDING.PRIVATE_DOMAIN,
SCREENS.ONBOARDING.WORKSPACES,
SCREENS.ONBOARDING.WORK_EMAIL,
SCREENS.ONBOARDING.WORK_EMAIL_VALIDATION,
SCREENS.ONBOARDING.WORKSPACE_OPTIONAL,
SCREENS.ONBOARDING.WORKSPACE_CONFIRMATION,
SCREENS.ONBOARDING.WORKSPACE_CURRENCY,
SCREENS.ONBOARDING.WORKSPACE_INVITE,
];

const FULL_SCREENS_SET = new Set([...Object.values(SIDEBAR_TO_SPLIT), NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR, SCREENS.WORKSPACES_LIST]);
const SIDEBARS_SET = new Set(Object.values(SPLIT_TO_SIDEBAR));
const ONBOARDING_SCREENS_SET = new Set(ONBOARDING_SCREENS);
const ONBOARDING_SCREENS_SET = new Set(Object.values(SCREENS.ONBOARDING));
const SPLIT_NAVIGATORS_SET = new Set(Object.values(SIDEBAR_TO_SPLIT));
const WORKSPACES_TAB_SET = new Set(Object.values([NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR, SCREENS.WORKSPACES_LIST]));

Expand Down
3 changes: 0 additions & 3 deletions src/libs/Navigation/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1943,9 +1943,6 @@ type WorkspaceSplitNavigatorParamList = {
};

type OnboardingModalNavigatorParamList = {
[SCREENS.ONBOARDING_MODAL.ONBOARDING]: {
backTo?: string;
};
[SCREENS.ONBOARDING.PERSONAL_DETAILS]: {
backTo?: string;
};
Expand Down
Loading