Add receipt partners to the more features page by waterim · Pull Request #68037 · Expensify/App

waterim · 2025-08-06T15:31:07Z

Details

Fixed Issues

$ #67526
PROPOSAL: N/A

Tests

Precondition:

User has added Wells Fargo card feed and assigned themselves Plaid Credit Card 3333.
"Allow deleting transactions" must be disabled in the card feed settings.
There is at least one imported card transaction.

Go to the workspace.
Open More features.
Observe 'receipt partners".
Toggle it.
Observe it in the LHN.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Details

melvin-bot · 2025-08-06T15:31:14Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2025-08-06T16:11:55Z

@waterim Should we add the feature flag for Receipt partners?

waterim · 2025-08-06T16:13:55Z

@dukenv0307 added!

dukenv0307 · 2025-08-06T16:16:05Z

@waterim Seems like ToggleReceiptPartners API is not available on BE side, right?

waterim · 2025-08-06T16:16:44Z

@dukenv0307 you are right!

…t.svg Co-authored-by: dukenv0307 <129500732+dukenv0307@users.noreply.github.com>

dukenv0307 · 2025-08-06T16:29:05Z

@waterim
Bug:
Receipt partner is highlighted when opening the category page

waterim · 2025-08-06T16:54:00Z

@dukenv0307 yes, thats a todo when a real page will appear

dukenv0307 · 2025-08-06T17:15:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-06.at.23.40.05.mov

Android: mWeb Chrome

Screen.Recording.2025-08-06.at.23.37.22.mov

iOS: HybridApp

Screen.Recording.2025-08-07.at.00.15.09.mov

iOS: mWeb Safari

Screen.Recording.2025-08-06.at.23.32.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-06.at.23.30.49.mov

MacOS: Desktop

Screen.Recording.2025-08-06.at.23.44.05.mov

dukenv0307 · 2025-08-06T17:15:46Z

LGTM

iwiznia · 2025-08-06T17:31:59Z

+            isActive: policy?.areReceiptPartnersEnabled ?? false,
+            pendingAction: policy?.pendingFields?.areReceiptPartnersEnabled,
+            disabledAction: () => {
+                // TODO: When Uber integration is added, check if any integration exists


Why can't we add this now?

We don't have any integrations in this PR, it just adding a workspace feature, for a disabledAction we need to get an receiptPartners from the policy and add a check (!hasReceiptPartnersIntegration) return;

iwiznia · 2025-08-06T17:32:13Z

+                setIsReceiptPartnersWarningModalOpen(true);
+            },
+            action: (isEnabled: boolean) => {
+                if (!policyID) {


How is this possible?

because policyID has type: string | undefined

Why? We can't be in the workspace more feature page without an ID

yes, but thats just a types, policyID is always like this on the pages

Not sure I follow. Are you saying this can never be falsy but we are checking everywhere anyway?
And if so, why would we do that?

Policy itself can be undefined in theory, thats why policyID is string | undefined also
Normally policy will not be undefined as we have a loading indicator for that, but thats just how withPolicyAndFullscreenLoading works, it returns policy object with type of policy or undefined

So actually this component will never be rendered with an undefined policy because FullscreenLoadingIndicator ensures that this component (or any other using it) is not rendered if the policy is not set?

Going to merge since this is not related to this PR really, is a broader conversation, but I am still interested in the answer of my question above.

It shouldn't, yes

iwiznia · 2025-08-06T17:32:47Z

+                }
+                enablePolicyReceiptPartners(policyID, isEnabled);
+            },
+            disabled: false, // TODO: When Uber integration is added, set to hasReceiptPartnersIntegration


Not sure what exactly this is referring to, can you clarify?

We need to show a toggle with a lock for receiptPartners when admin already configured uber integration and in order to disable receiptPartners they need to disable uber integration first

And for that we need to get from the policy data if uber exists in policy or no

const hasReceiptPartnersIntegration = !isEmptyObject(policy?.receiptPartners);

As I can see in the @narefyev91 PR he already added typings and we will need just to add a one line verification here

Don't get why you can't add this now. The api should already be returning this, but even if it is not, you can still assume it will be there.
Also, !isEmptyObject(policy?.receiptPartners); is probably not correct, as that will always return true, since it will contain the enabled: true property

Don't get why you can't add this now. The api should already be returning this, but even if it is not, you can still assume it will be there.

Okay, sure, I will update types here in this PR

dubielzyk-expensify · 2025-08-06T23:00:18Z

From a design perspective this is looking good 👍

OSBotify · 2025-08-07T14:29:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-08T02:29:36Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.91-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-12T04:08:57Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.92-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

waterim added 7 commits August 6, 2025 17:27

update translations

1d3a287

add new illustration

a2f0918

add new screen

61ae774

add new enabled CONST

d73b6eb

add new command

4adc03e

add new disabled modal and more features toggle

0fa4c35

updates

cd8f3df

waterim requested review from a team as code owners August 6, 2025 15:31

melvin-bot Bot requested review from dukenv0307 and removed request for a team August 6, 2025 15:31

fix prettier

cc58986

dukenv0307 reviewed Aug 6, 2025

View reviewed changes

Comment thread assets/images/simple-illustrations/simple-illustration__receipt.svg Outdated

add new BETA

6e4d6a9

add beta usage

d015ed6

Update assets/images/simple-illustrations/simple-illustration__receip…

df82748

…t.svg Co-authored-by: dukenv0307 <129500732+dukenv0307@users.noreply.github.com>

dukenv0307 approved these changes Aug 6, 2025

View reviewed changes

melvin-bot Bot requested a review from iwiznia August 6, 2025 17:16

iwiznia reviewed Aug 6, 2025

View reviewed changes

updates

c0870db

iwiznia approved these changes Aug 7, 2025

View reviewed changes

iwiznia merged commit af6b5ed into Expensify:main Aug 7, 2025
27 checks passed

github-actions Bot mentioned this pull request Aug 8, 2025

Deploy Checklist: New Expensify 2025-08-08 #68168

Closed

75 tasks

melvin-bot Bot mentioned this pull request Aug 12, 2025

[Due for payment 2025-08-19] Add receipt partners to the more features page #67526

Closed

Conversation

waterim commented Aug 6, 2025

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 6, 2025

Uh oh!

Uh oh!

dukenv0307 commented Aug 6, 2025

Uh oh!

waterim commented Aug 6, 2025

Uh oh!

dukenv0307 commented Aug 6, 2025

Uh oh!

waterim commented Aug 6, 2025

Uh oh!

dukenv0307 commented Aug 6, 2025

Uh oh!

waterim commented Aug 6, 2025

Uh oh!

dukenv0307 commented Aug 6, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Aug 6, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

waterim Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

waterim Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Aug 6, 2025

Uh oh!

Uh oh!

OSBotify commented Aug 7, 2025

Uh oh!

github-actions Bot commented Aug 8, 2025

Uh oh!

github-actions Bot commented Aug 12, 2025

waterim Aug 7, 2025 •

edited

Loading

waterim Aug 7, 2025 •

edited

Loading