fix: Scan - Image can be dropped on scan zone in room when there are 2 members which leads to error. by Krishna2323 · Pull Request #68084 · Expensify/App

Krishna2323 · 2025-08-07T05:52:33Z

Explanation of Change

Fixed Issues

$ #66643
PROPOSAL: #66643 (comment)

Tests

Note: Tests are only for Web and Desktop app, mWeb and native app does not support drag and drop

Open FAB > Start chat > Room.
Create a room.
Open room header > Members.
Invite two members to the room.
Close the RHP.
Drag and image over drag and drop area.
Verify only attachment drop area is shown
Go to a group chat
Drag and image over drag and drop area.
Verify only attachment drop area is shown
Go to self report
Drag and drop an image to Scan zone.
Verify scan request confirmation page appears
Confirm scan request is created without any error
Go go policy expense chat
Drag and drop an image to Scan zone.
Verify scan request confirmation page appears
Confirm scan request
Verify scan request confirmation page appears

Verify that no errors appear in the JS console

Offline tests

Note: Tests are only for Web and Desktop app, mWeb and native app does not support drag and drop

Open FAB > Start chat > Room.
Create a room.
Open room header > Members.
Invite two members to the room.
Close the RHP.
Drag and image over drag and drop area.
Verify only attachment drop area is shown
Go to a group chat
Drag and image over drag and drop area.
Verify only attachment drop area is shown
Go to self report
Drag and drop an image to Scan zone.
Verify scan request confirmation page appears
Confirm scan request is created without any error
Go go policy expense chat
Drag and drop an image to Scan zone.
Verify scan request confirmation page appears
Confirm scan request
Verify scan request confirmation page appears

QA Steps

Note: Tests are only for Web and Desktop app, mWeb and native app does not support drag and drop

Open FAB > Start chat > Room.
Create a room.
Open room header > Members.
Invite two members to the room.
Close the RHP.
Drag and image over drag and drop area.
Verify only attachment drop area is shown
Go to a group chat
Drag and image over drag and drop area.
Verify only attachment drop area is shown
Go to self report
Drag and drop an image to Scan zone.
Verify scan request confirmation page appears
Confirm scan request is created without any error
Go go policy expense chat
Drag and drop an image to Scan zone.
Verify scan request confirmation page appears
Confirm scan request
Verify scan request confirmation page appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

Monosnap.screencast.2025-09-06.12-54-44.mp4

MacOS: Desktop

desktop_app.1.mp4

…2 members which leads to error. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-08-08T12:57:17Z

Facing an issue on desktop app, will try to fix it in this PR but it doesn't seem related.

Monosnap.screencast.2025-08-08.18-26-11.mp4

melvin-bot · 2025-08-25T06:45:40Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jasperhuangg · 2025-08-28T13:53:43Z

Reached out here to find a new C+ to take over

hoangzinh · 2025-08-29T01:41:53Z

Thank you for spinning up a PR @Krishna2323. Give me some time to read the issue context first.

hoangzinh · 2025-08-29T01:52:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-29.at.20.51.12.android.mov

Android: mWeb Chrome

Screen.Recording.2025-08-29.at.20.44.48.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-08-29.at.21.02.25.ios.mov

iOS: mWeb Safari

Screen.Recording.2025-08-29.at.21.03.34.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-10.at.05.18.04.mov

MacOS: Desktop

Screen.Recording.2025-09-10.at.05.20.27.mov

hoangzinh · 2025-08-29T02:03:36Z

+    const preferredOrder: IOUType[] = [CONST.IOU.TYPE.TRACK, CONST.IOU.TYPE.SUBMIT, CONST.IOU.TYPE.SPLIT];
+    return preferredOrder.find((type) => iouOptions.includes(type) && (type !== 'track' || isSelfDM(report)));


Suggested change

const preferredOrder: IOUType[] = [CONST.IOU.TYPE.TRACK, CONST.IOU.TYPE.SUBMIT, CONST.IOU.TYPE.SPLIT];

return preferredOrder.find((type) => iouOptions.includes(type) && (type !== 'track' || isSelfDM(report)));

if (isSelfDM(report) && iouOptions.includes(CONST.IOU.TYPE.TRACK)) {

return CONST.IOU.TYPE.TRACK;

}

const preferredOrder: IOUType[] = [CONST.IOU.TYPE.SUBMIT, CONST.IOU.TYPE.SPLIT];

return preferredOrder.find((type) => iouOptions.includes(type));

I think it would be simpler. Beside that, can you add a test for this new util?

Updated and added a util test.

hoangzinh · 2025-08-29T02:04:52Z


    const hasReceipt = useMemo(() => hasReceiptTransactionUtils(transaction), [transaction]);

+    const scannableOption = getPreferredScannableIOUType(temporary_getMoneyRequestOptions(report, policy, reportParticipantIDs, isReportArchived), report);


Suggested change

const scannableOption = getPreferredScannableIOUType(temporary_getMoneyRequestOptions(report, policy, reportParticipantIDs, isReportArchived), report);

const scannableIouType = getPreferredScannableIOUType(temporary_getMoneyRequestOptions(report, policy, reportParticipantIDs, isReportArchived), report);

Besides that, should we add useMemo for this?

Yes, I think it's a good idea. Updated.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hoangzinh · 2025-08-29T11:26:49Z

@Krishna2323 can you elaborate what are differents between step 6-9 and step 11-14

hoangzinh · 2025-08-29T11:28:40Z

Besides that, can you also add a note that those tests are only for Web/Desktop?

Krishna2323 · 2025-08-30T19:45:27Z

can you elaborate what are differents between step 6-9 and step 11-14

The steps are same but one is performed in a room chat and the other one in a group chat.

hoangzinh

Thanks. LGTM

trjExpensify

@lakchote @koko57 - tagging ya'll for vis here with regards to drag and drop. Just confirming whether we had creating a split in a groupDM or room in scope?

koko57 · 2025-09-02T11:36:46Z

@lakchote @koko57 - tagging ya'll for vis here with regards to drag and drop. Just confirming whether we had creating a split in a groupDM or room in scope?

no, as far as I remember we blocked the possibility to drop on groupDM or room

koko57 · 2025-09-02T11:39:11Z

two option is Receipt dropzone and Attachment dropzone - in other like group dm or room we only should display Attachment dropzone

lakchote · 2025-09-02T15:51:32Z

^ @koko57 is correct

hoangzinh · 2025-09-02T22:33:28Z

@Krishna2323 looks like we should disable scan zone in group dm or room

trjExpensify · 2025-09-03T13:29:54Z

@koko57 is correct

Cool, thanks for confirming both!

@Krishna2323 looks like we should disable scan zone in group dm or room

Yes, we should do this.

Krishna2323 · 2025-09-04T09:05:47Z

I'll update this PR today.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-09-06T07:43:47Z

@hoangzinh updated:

Monosnap.screencast.2025-09-06.12-54-44.mp4

hoangzinh · 2025-09-07T19:07:57Z

-                    CONST.IOU.OPTIMISTIC_TRANSACTION_ID,
-                    reportID,
-                ),
+                ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(CONST.IOU.ACTION.CREATE, scannableIouType ?? CONST.IOU.TYPE.SUBMIT, CONST.IOU.OPTIMISTIC_TRANSACTION_ID, reportID),


It seems we don't really need this, do we? If yes, can we revert this code?

hoangzinh · 2025-09-08T01:38:07Z

        const isSettledOrApproved = isSettled(report) || isSettled(parentReport) || isReportApproved({report}) || isReportApproved({report: parentReport});
-        return (shouldAddOrReplaceReceipt && !isSettledOrApproved) || !!temporary_getMoneyRequestOptions(report, policy, reportParticipantIDs, isReportArchived).length;
-    }, [shouldAddOrReplaceReceipt, report, policy, reportParticipantIDs, isReportArchived]);
+        return ((shouldAddOrReplaceReceipt && !isSettledOrApproved) || !!scannableIouType) && canRequestMoney;


@Krishna2323 do you think it's better if we explicitly exclude group chat and room here? I guess it will be easier to extend the feature later, as canRequestMoney is more complex.

Agree with you, updated the code.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hoangzinh

LGTM

hoangzinh · 2025-09-09T22:23:44Z

Please help review this PR again when you have time. cc @trjExpensify @jasperhuangg

trjExpensify · 2025-09-10T17:11:06Z

I'm happy with #68084 (comment) 👍

OSBotify · 2025-09-10T18:32:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-10T23:28:53Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.2.9-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-11T11:10:12Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.2.11-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-12T00:15:46Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Krishna2323 added 3 commits August 7, 2025 11:00

fix: Scan - Image can be dropped on scan zone in room when there are …

5c77c3f

…2 members which leads to error. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

minor fixes.

f23275a

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/66643

c896fd0

Merge branch 'Expensify:main' into krishna2323/issue/66643

27ae158

Krishna2323 mentioned this pull request Aug 12, 2025

[Due for payment 2025-09-19] [$250] Scan - Image can be dropped on scan zone in room when there are 2 members which leads to error #66643

Closed

8 tasks

Krishna2323 added 2 commits August 13, 2025 18:14

Merge branch 'Expensify:main' into krishna2323/issue/66643

974f994

Merge branch 'Expensify:main' into krishna2323/issue/66643

2ae422d

Krishna2323 marked this pull request as ready for review August 25, 2025 06:45

Krishna2323 requested a review from a team as a code owner August 25, 2025 06:45

melvin-bot Bot requested review from rushatgabhane and removed request for a team August 25, 2025 06:45

jasperhuangg removed the request for review from rushatgabhane August 28, 2025 13:53

jasperhuangg requested a review from hoangzinh August 28, 2025 13:58

hoangzinh reviewed Aug 29, 2025

View reviewed changes

minor updates.

acd0b11

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner August 29, 2025 07:58

Krishna2323 added 2 commits August 29, 2025 13:32

add unit tests for getPreferredScannableIOUType.

4ec39af

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/66643

00bf2a0

hoangzinh reviewed Aug 29, 2025

View reviewed changes

Comment thread tests/unit/ReportUtilsTest.ts Outdated

update test description.

1e94936

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hoangzinh approved these changes Aug 31, 2025

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg August 31, 2025 05:53

trjExpensify reviewed Sep 2, 2025

View reviewed changes

Krishna2323 added 2 commits September 5, 2025 23:57

Merge branch 'Expensify:main' into krishna2323/issue/66643

f340b66

disable drag and drop receipts in group and room chats.

cdb88ea

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hoangzinh reviewed Sep 7, 2025

View reviewed changes

hoangzinh reviewed Sep 8, 2025

View reviewed changes

Krishna2323 added 3 commits September 9, 2025 00:30

update shouldDisplayDualDropZone condition.

e2ccd23

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

remove getPreferredScannableIOUType unit tests.

c806bc8

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/66643

1844fea

hoangzinh approved these changes Sep 9, 2025

View reviewed changes

jasperhuangg approved these changes Sep 10, 2025

View reviewed changes

jasperhuangg merged commit 40d51fc into Expensify:main Sep 10, 2025
21 checks passed

OSBotify mentioned this pull request Sep 10, 2025

Deploy Checklist: New Expensify 2025-09-10 #70325

Closed

		const preferredOrder: IOUType[] = [CONST.IOU.TYPE.TRACK, CONST.IOU.TYPE.SUBMIT, CONST.IOU.TYPE.SPLIT];
		return preferredOrder.find((type) => iouOptions.includes(type) && (type !== 'track' \|\| isSelfDM(report)));

-    const preferredOrder: IOUType[] = [CONST.IOU.TYPE.TRACK, CONST.IOU.TYPE.SUBMIT, CONST.IOU.TYPE.SPLIT];
-    return preferredOrder.find((type) => iouOptions.includes(type) && (type !== 'track' || isSelfDM(report)));
+    if (isSelfDM(report) && iouOptions.includes(CONST.IOU.TYPE.TRACK)) {
+        return CONST.IOU.TYPE.TRACK;
+    }
+    const preferredOrder: IOUType[] = [CONST.IOU.TYPE.SUBMIT, CONST.IOU.TYPE.SPLIT];
+    return preferredOrder.find((type) => iouOptions.includes(type));


		const hasReceipt = useMemo(() => hasReceiptTransactionUtils(transaction), [transaction]);

		const scannableOption = getPreferredScannableIOUType(temporary_getMoneyRequestOptions(report, policy, reportParticipantIDs, isReportArchived), report);

	const scannableOption = getPreferredScannableIOUType(temporary_getMoneyRequestOptions(report, policy, reportParticipantIDs, isReportArchived), report);
	const scannableIouType = getPreferredScannableIOUType(temporary_getMoneyRequestOptions(report, policy, reportParticipantIDs, isReportArchived), report);

Conversation

Krishna2323 commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Aug 8, 2025

Uh oh!

melvin-bot Bot commented Aug 25, 2025

Uh oh!

jasperhuangg commented Aug 28, 2025

Uh oh!

hoangzinh commented Aug 29, 2025

Uh oh!

hoangzinh commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hoangzinh commented Aug 29, 2025

Uh oh!

hoangzinh commented Aug 29, 2025

Uh oh!

Krishna2323 commented Aug 30, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

koko57 commented Sep 2, 2025

Uh oh!

koko57 commented Sep 2, 2025

Uh oh!

lakchote commented Sep 2, 2025

Uh oh!

hoangzinh commented Sep 2, 2025

Uh oh!

trjExpensify commented Sep 3, 2025

Uh oh!

Krishna2323 commented Sep 4, 2025

Uh oh!

Krishna2323 commented Sep 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Sep 9, 2025

Uh oh!

trjExpensify commented Sep 10, 2025

Uh oh!

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 11, 2025

Krishna2323 commented Aug 7, 2025 •

edited

Loading

hoangzinh commented Aug 29, 2025 •

edited

Loading