Skip to content

Anthony remove second secure inputs#6809

Merged
chiragsalian merged 4 commits into
Expensify:mainfrom
anthony-hull:anthony--remove-second-secure-inputs
Dec 22, 2021
Merged

Anthony remove second secure inputs#6809
chiragsalian merged 4 commits into
Expensify:mainfrom
anthony-hull:anthony--remove-second-secure-inputs

Conversation

@anthony-hull

@anthony-hull anthony-hull commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

Details

Fixed Issues

$ #6565
$ #6823

QA Steps

  1. Create a new account

  2. Click the link in the email

  3. Verify the password form works (including some invalid password states)

  4. Submit the form and verify it allows you to set the password with a valid password

  5. Given being logged in

  6. Navigate to the change password setting

  7. Verify the password form works (including some invalid password states)

  8. Submit the form and verify it allows you to change with a valid password

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@anthony-hull anthony-hull marked this pull request as ready for review December 20, 2021 11:40
@anthony-hull anthony-hull requested a review from a team as a code owner December 20, 2021 11:40
@MelvinBot MelvinBot removed the request for review from a team December 20, 2021 11:40
@anthony-hull

Copy link
Copy Markdown
Contributor Author

sorry I'm having issues testing in Android at the moment. I'll have a go fixing my env again tonight

@parasharrajat

Copy link
Copy Markdown
Member

I will wait for your tests..

Comment thread src/pages/settings/PasswordPage.js
Comment thread src/pages/settings/PasswordPage.js
@parasharrajat

Copy link
Copy Markdown
Member

@anthony-hull Could you please test it on Android? Thanks

@anthony-hull

Copy link
Copy Markdown
Contributor Author

I've updated the post with the android screenshot

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @chiragsalian

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

@chiragsalian chiragsalian merged commit be6dccf into Expensify:main Dec 22, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mountiny

Copy link
Copy Markdown
Contributor

Edited the PR body to also link to the other issue this PR fixes.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.23-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants