Anthony remove second secure inputs#6809
Merged
chiragsalian merged 4 commits intoDec 22, 2021
Merged
Conversation
Contributor
Author
|
sorry I'm having issues testing in Android at the moment. I'll have a go fixing my env again tonight |
Member
|
I will wait for your tests.. |
parasharrajat
suggested changes
Dec 20, 2021
Member
|
@anthony-hull Could you please test it on Android? Thanks |
Contributor
Author
|
I've updated the post with the android screenshot |
parasharrajat
approved these changes
Dec 21, 2021
parasharrajat
left a comment
Member
There was a problem hiding this comment.
LGTM.
cc: @chiragsalian
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
Edited the PR body to also link to the other issue this PR fixes. |
44 tasks
Contributor
|
🚀 Deployed to staging by @chiragsalian in version: 1.1.23-2 🚀
|
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #6565
$ #6823
QA Steps
Create a new account
Click the link in the email
Verify the password form works (including some invalid password states)
Submit the form and verify it allows you to set the password with a valid password
Given being logged in
Navigate to the change password setting
Verify the password form works (including some invalid password states)
Submit the form and verify it allows you to change with a valid password
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android