Skip to content

Added keyboardType to cvv#6810

Merged
Julesssss merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/cvv-keyboard-type
Dec 17, 2021
Merged

Added keyboardType to cvv#6810
Julesssss merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/cvv-keyboard-type

Conversation

@mananjadhav

@mananjadhav mananjadhav commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

Details

  • Added keyboardType to cvv

Fixed Issues

$ #6748

Tests

  1. Tested the keyboard type on all mobile platforms.

QA Steps

  1. Go to settings -> Payments
  2. Click on "Add Debit Card"
  3. Focus on CVV field, ensure that it shows number pad.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

mweb-keyboardtype-cvv

Desktop

iOS

ios-keyboardtype-cvv

Android

android-keyboardtype-cvv

@mananjadhav mananjadhav requested a review from a team as a code owner December 16, 2021 23:31
@MelvinBot MelvinBot requested review from Julesssss and parasharrajat and removed request for a team December 16, 2021 23:31

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge @Julesssss

@Julesssss Julesssss merged commit a43b510 into Expensify:main Dec 17, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.21-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants