Corrected - IOU Cursor is set to pointer in IOU preview#6832
Merged
Conversation
MelvinBot
requested review from
parasharrajat and
stitesExpensify
and removed request for
a team
parasharrajat
suggested changes
Dec 18, 2021
parasharrajat
approved these changes
Dec 18, 2021
parasharrajat
left a comment
parasharrajat
left a comment
Member
There was a problem hiding this comment.
LGTM.
cc: @stitesExpensify
stitesExpensify
approved these changes
Dec 28, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
44 tasks
Contributor
|
🚀 Deployed to staging by @stitesExpensify in version: 1.1.23-2 🚀
|
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@parasharrajat @mallenexpensify PR is ready for review.
Details
User can see pointer when mouse over on IOU Preview in details modal at RHN, but there is no action occurring when clicking on it. So in this PR corrected cursor behaviour. i.e. Now it will show default cursor when mouse over on IOU Preview. This cursor behaviour is visible on Web and Desktop version.
Proposal: #6693 (comment)
Fixed Issues
$ #6693
Tests | QA Steps
QA Check: Within Web and Desktop it will show default cursor because it is not clickable. (previously it was showing pointer).
Tested On
Screenshots
Web
Web.mov
Mobile Web
MobileWeb.mov
Desktop
Desktop.mov
iOS
iOS.mov
Android
Android.mov