Skip to content

Rename ExpensifyText#6835

Merged
puneetlath merged 4 commits into
Expensify:mainfrom
mateusbra:rename-expensifytext
Dec 23, 2021
Merged

Rename ExpensifyText#6835
puneetlath merged 4 commits into
Expensify:mainfrom
mateusbra:rename-expensifytext

Conversation

@mateusbra

Copy link
Copy Markdown
Contributor

Details

Rename component ExpensifyText to Text

Fixed Issues

$ #6760

Tests

  1. Run the app and see that Text still working

QA Steps

  1. Run the app and see that Text still working

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web

Mobile Web

Mobile Web

Desktop

Desktop

iOS

IOS

Android

Android

@mateusbra mateusbra requested a review from a team as a code owner December 18, 2021 23:36
@MelvinBot MelvinBot requested review from parasharrajat and puneetlath and removed request for a team December 18, 2021 23:36
parasharrajat
parasharrajat previously approved these changes Dec 21, 2021

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
cc: @puneetlath

puneetlath
puneetlath previously approved these changes Dec 23, 2021

@puneetlath puneetlath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Looks like you have one merge conflict that needs addressing. Then we should be good to go.

@puneetlath puneetlath merged commit fbb4674 into Expensify:main Dec 23, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.23-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants