Show permission error dialog only when storage permission is denied or missing

[aswin-s]

Details

Fixes a bug on android devices where permission error dialog was shown even when storage permission is allowed by the user.

Fixed Issues

$ #6613

Tests

1. Open app in an Android device.
2. Open a conversation with an attachment in it.
3. Tap on the attachment to view it in Attachment view
4. Tap on download icon to download the attachment.
5. Download success message should be shown.
6. Now kill the app, remove storage permission for New Expensify from settings.
7. Repeat steps 2-4.
8. Tap on Deny when os dialog for file permission is shown.
9. Tap on deny button to deny permission.
10. Permission error dialog should be shown to user.

QA Steps

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

permission.mp4

[parasharrajat]

As the change only affects native devices, I am skipping screenshot check for other platforms.

LGTM.

cc: @thienlnam

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @thienlnam in version: 1.1.23-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅