[NO QA] Fix Retry Payment when failed for authentication#68457
Conversation
amyevans
left a comment
There was a problem hiding this comment.
just a few quick notes if they're helpful
Co-authored-by: Amy Evans <amy@expensify.com>
…to rodrigo-improve-retrypaymnet
|
Im not sure what is up with the failed iOS build, but some discussion around it here https://expensify.slack.com/archives/C03TQ48KC/p1755193289596359 |
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Sorry for the ping, I think C+ can't really test this. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.1.98-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.98-12 🚀
|
Explanation of Change
If we failed a purchase and have the authentication link it means we should redirect the user to the 3ds modal, so this pr does that.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/533928
PROPOSAL:
Tests
4000008260003178)../script/clitools.sh billingrunfor the current monthOffline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-08-15.at.10.33.37.mov
MacOS: Desktop