Fix gsd mode pinned room not on the top

[K4tsuki]

Details

Fixed Issues

$ #6563

Tests

1. On LHN there must be two or more pinned reports
2. On LHN there must be one or more unpinned unread reports or have outstanding IOU
3. The unread reports name should be between or before the pinned reports ordered alphabetically
4. Change LHN mode to focus mode
5. The pinned reports must be on top, alphabetically ordered
6. The unpinned reports that have unread or outstanding IOU must be bellow pinned reports ordered alphabetically

QA Steps

1. On LHN there should be two or more pinned reports
2. On LHN there must be one or more unpinned unread reports or have outstanding IOU
3. The unread report names should be between or before the pinned reports ordered alphabetically
4. Change LHN mode to focus mode
5. The pinned reports must be on top, ordered alphabetically
6. The unpinned reports that have unread or outstanding IOU must be bellow pinned reports ordered alphabetically

Tested On

• [v] Web
• [v] Mobile Web
• Desktop
• iOS
• [v] Android

Screenshots

Before

After

Web

Mobile Web

Desktop

iOS

Android

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[K4tsuki]

I have read the CLA Document and I hereby sign the CLA

[parasharrajat]

Also, it's strange but I can't see who signed the commits. Could you please resign your commits so that we can see your name with the GPG key?

[K4tsuki]

Also, it's strange but I can't see who signed the commits. Could you please resign your commits so that we can see your name with the GPG key?

I have signed the last commit.

[parasharrajat]

@K4tsuki You would need to sign all the commits and also please purge the last four unnecessary commits. You would need to rebase them. Thanks.

[K4tsuki]

@K4tsuki You would need to sign all the commits and also please purge the last four unnecessary commits. You would need to rebase them. Thanks.

Done

[parasharrajat]

LGTM.

cc: @Luke9389

[mallenexpensify]

@Luke9389 is back on Monday and will review then, apologies for the delay @K4tsuki

[K4tsuki]

@Luke9389 is back on Monday and will review then, apologies for the delay @K4tsuki

No problem @mallenexpensify .

[Luke9389]

Nice, thanks!

[parasharrajat]

🎀 👀 🎀 C+ reviewed

[K4tsuki]

@Luke9389 All cheks have passed.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @Luke9389 in version: 1.1.27-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @Luke9389 in version: 1.1.27-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @Luke9389 in version: 1.1.27-3 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

[OSBotify]

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[K4tsuki]

@parasharrajat How about sorting issue here?
Currently the sorting is case sensitive. Should we make it case insensitive?
Should we make another pull request?

[mallenexpensify]

@parasharrajat can you reply to @K4tsuki above?
#6849 (comment)

[parasharrajat]

Aha, that's a good point. But this is a question for slack. @K4tsuki

[K4tsuki]

slack: https://app.slack.com/client/T03SC9DTT/C01GTK53T8Q/thread/C01GTK53T8Q-1642834751.312800