Jakubkalinski0/fix console errors related to forward ref batch4 by jakubkalinski0 · Pull Request #68843 · Expensify/App

jakubkalinski0 · 2025-08-20T09:35:58Z

Explanation of Change

The whole issue comes from forwardRef being deprecated in the near future of react thus we will no longer be able to access the passed ref by element.ref as forwardRef is needed for passing ref as a separate attribute. Now in order to pass there reference it has to be passed as one of the props so we can access it directly or like that -> element.props.ref.

In order to adjust the codebase to new react recommendations in every file that was using forwardRef the ref had to be moved to the props instead of being a separate attribute and forwardRef had to be completely removed.

Some files had to be changed due to the changes made in other components. In response to the number of files that needed adjusting the changes are made in batches with this one being the fourth one.

In this batch I mostly took care of Create Manual Expense flow. At first it was part of one PR which was supposed to cover whole create expense flow but it grew too big. This batch touches plenty of components responsible for handling input from user.

Manual money request ->

src/pages/iou/MoneyRequestAmountForm.tsx

src/components/MoneyRequestAmountInput.tsx

src/components/NumberWithSymbolForm.tsx

src/components/TextInputWithSymbol/BaseTextInputWithSymbol.tsx
src/components/TextInputWithSymbol/index.android.tsx
src/components/TextInputWithSymbol/index.tsx
src/components/TextInputWithSymbol/index.web.tsx
src/components/TextInputWithSymbol/types.ts

src/components/AmountTextInput.tsx

src/components/TextInput/BaseTextInput/implementation/index.native.tsx
src/components/TextInput/BaseTextInput/implementation/index.tsx
src/components/TextInput/BaseTextInput/index.e2e.tsx
src/components/TextInput/BaseTextInput/types.ts
src/components/TextInput/index.native.tsx
src/components/TextInput/index.tsx

src/components/RNTextInput.tsx
src/components/RNMarkdownTextInput.tsx
src/components/RNMaskedTextInput.tsx

Those required change in order for certain inputs using them to work without forwardRef ->

src/components/AmountForm.tsx
src/components/Form/FormProvider.tsx

These here had to be changed in response to the changes made in other files. They required only cosmetic changes which cannot produce any issues and thus they require no testing ->

src/components/AmountPicker/AmountSelectorModal.tsx
src/components/Composer/implementation/index.native.tsx
src/components/PercentageForm.tsx
src/components/SubStepForms/AddressStep.tsx
src/components/TextPicker/types.ts
src/components/TextInput/BaseTextInput/implementations.ts
src/pages/PrivateNotes/PrivateNotesEditPage.tsx
src/pages/iou/request/step/IOURequestStepAmount.tsx
src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx
src/pages/settings/Profile/CustomStatus/StatusPage.tsx
src/pages/settings/Security/MergeAccounts/AccountDetailsPage.tsx
src/pages/settings/Wallet/InternationalDepositAccount/substeps/AccountType.tsx
src/pages/workspace/reports/CreateReportFieldsPage.tsx

Fixed Issues

$ #67033
PROPOSAL:

Tests

When you have your app on, open DevTools console
Throughout this whole flow look out in console for any new errors while inputing the amount or while writing in 1:1 chat
Click on the floating "+" button in the navigation bar on the left or in the 1:1 chat.
Press "Create Expense"
When the sidePanel on the right opens choose "Manual"
Change the currency
Input the amount
Verify that the input works
Press "Next" button
Press "Create X amount expense" button
Go to 1:1 chat
Input any message
Verify that input works
Send message

Verify that no errors appear in the JS console

Offline tests

SAME AS TESTS ^

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

SAME AS TESTS ^

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

2.mov

MacOS: Desktop

…itPage.tsx

…it led to errors

…onents using it

…y NumberWithSymbolForm

melvin-bot · 2025-08-20T09:36:04Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

…-forwardRef-batch4

SzymczakJ

LGTM, left one small comment

melvin-bot · 2025-08-20T15:57:24Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2025-08-25T03:53:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-08-25.at.8.51.40.AM.mov

iOS: HybridApp

Screen.Recording.2025-08-25.at.8.50.27.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-08-25.at.8.49.18.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-25.at.8.40.05.AM.mov

MacOS: Desktop

Screen.Recording.2025-08-25.at.8.44.54.AM.mov

allroundexperts

Works good!

mountiny

Thanks! One NAB comment, moving this ahead

mountiny · 2025-08-25T12:15:58Z

                        forwardedRef(ref);
                    } else if (forwardedRef && 'current' in forwardedRef) {
-                        // eslint-disable-next-line no-param-reassign
+                        // eslint-disable-next-line no-param-reassign, react-compiler/react-compiler


How to do this to follow the rules of React so we do not have to skip the compiler? We will start enforcing it soon so I think ideally this is fixed as well so we do not skip react compiler

I will look if it can be done

@mountiny FYI it appears those actually had to be introduced because of the improper handling of refs that caused issues with the autoFocus (which should have been the first sign of something not being right here 😅). So after the autoFocus fix is merged we will no longer be skipping the compiler here 🚀

OSBotify · 2025-08-25T12:27:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-08-26T11:20:56Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.99-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-08-28T01:18:41Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jakubkalinski0 added 21 commits August 20, 2025 10:53

Removed forwardRef from NumberWithSymbolForm.tsx

54bb79e

Removed forwardRef from AmountForm.tsx

0a4215b

Added ? to forwardedRef in NumberWithSymbolFormProps.tsx

4b576b1

Corrected the prop name in AmountSelectorModal.tsx

918b90f

Corrected the prop name in MoneyRequestAmountInput.tsx

32e1df1

Added ? to forwardedRef in AmountForm.tsx

5abb8b0

Removed forwardRef from Form/FormProvider.tsx

11142b9

Adjusted prop ref prop name in SubStepForms/AddressStep.tsx

2c9e3bc

Adjusted type of ref that is forwarded in PrivateNotes/PrivateNotesEd…

f75d10e

…itPage.tsx

Adjusted ref names in places where FormProvider is used

76b3d0b

Removed forwardRef from BaseTextInput component

71271dd

Adjusted TextInput so that the InputComponentMap works properly

010e7c5

Adjusted refs types of components using TextInput

6dfac3e

Adjusted TextSelectorModalProps to not include ref from TextProps as …

0cf263c

…it led to errors

Removed forwardRef from TextInput component

d8bff05

Adjusted imports of TextInput/index.tsx

e1fcb25

Removed forwardRef from TextInputWithSymbol component

c92372a

Removed forwardRef from AmountTextInput.tsx

242502c

Removed forwardRef from MoneyRequestAmountInput.tsx and adjusted comp…

7870690

…onents using it

Adjusted type of ref being forwarded to TextInputWithCurrencySymbol b…

8ce4108

…y NumberWithSymbolForm

Prettier run

43a7411

melvin-bot Bot assigned jakubkalinski0 Aug 20, 2025

jakubkalinski0 force-pushed the jakubkalinski0/Fix-console-errors-related-to-forwardRef-batch4 branch from cb3d4cf to 43a7411 Compare August 20, 2025 10:16

jakubkalinski0 added 3 commits August 20, 2025 12:34

Resolved errors from eslint

ec68193

Got rid of deprecated MutableRefObject

9e17219

Merge branch 'main' into jakubkalinski0/Fix-console-errors-related-to…

5acdd9f

…-forwardRef-batch4

SzymczakJ approved these changes Aug 20, 2025

View reviewed changes

Comment thread src/components/PercentageForm.tsx

jakubkalinski0 marked this pull request as ready for review August 20, 2025 15:57

jakubkalinski0 requested a review from a team as a code owner August 20, 2025 15:57

melvin-bot Bot requested a review from allroundexperts August 20, 2025 15:57

melvin-bot Bot removed the request for review from a team August 20, 2025 15:57

allroundexperts approved these changes Aug 25, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny August 25, 2025 03:57

mountiny approved these changes Aug 25, 2025

View reviewed changes

mountiny merged commit cf9d8d5 into Expensify:main Aug 25, 2025
26 of 36 checks passed

OSBotify mentioned this pull request Aug 26, 2025

Deploy Checklist: New Expensify 2025-08-26 #69233

Closed

Eskalifer1 mentioned this pull request Aug 26, 2025

Workspace - Input field does not auto focus in Distance rates > Add rate page #69242

Closed

8 tasks

melvin-bot Bot mentioned this pull request Aug 28, 2025

[Due for payment 2026-02-03] [$1000] Fix console errors post React 19 upgrade #67033

Closed

Conversation

jakubkalinski0 commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 20, 2025

Uh oh!

SzymczakJ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented Aug 20, 2025

Uh oh!

allroundexperts commented Aug 25, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

jakubkalinski0 Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

jakubkalinski0 Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Aug 25, 2025

Uh oh!

OSBotify commented Aug 26, 2025

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jakubkalinski0 commented Aug 20, 2025 •

edited

Loading