Add onfido logs#6892
Merged
Merged
Conversation
nkuoch
force-pushed
the
nat-onfidologs
branch
from
65bdac7 to
c064289
Compare
marcaaron
previously approved these changes
Dec 23, 2021
| }, | ||
| onError: (error) => { | ||
| const errorMessage = lodashGet(error, 'message', CONST.ERROR.UNKNOWN_ERROR); | ||
| Log.hmmm('Onfido error', {errorType: error.type, errorMessage}); |
Contributor
There was a problem hiding this comment.
NAB, not sure if this is possible but if error is undefined this could throw. Then again, maybe we trust Onfido to always pass something to this callback... 😄
Contributor
Author
|
updated |
marcaaron
approved these changes
Dec 24, 2021
Contributor
|
Looks great thanks for these changes 🙇 |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
44 tasks
Contributor
|
🚀 Deployed to staging by @marcaaron in version: 1.1.23-2 🚀
|
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adding logs, similar to what we already have on secure, to help us debug user issues.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/150155
Tests
Made sure I could see the analytics Onfido logs
QA Steps
None
Tested On
Screenshots