Skip to content

Update guidelines on bugs not happening in production#6895

Merged
danieldoglas merged 2 commits into
mainfrom
iwiznia-patch-1-1
Dec 30, 2021
Merged

Update guidelines on bugs not happening in production#6895
danieldoglas merged 2 commits into
mainfrom
iwiznia-patch-1-1

Conversation

@iwiznia

@iwiznia iwiznia commented Dec 23, 2021

Copy link
Copy Markdown
Contributor

Context https://expensify.slack.com/archives/C02NK2DQWUX/p1640209639081000

This is just a process change, no need to QA or test.

@iwiznia iwiznia self-assigned this Dec 23, 2021
@iwiznia iwiznia requested a review from a team as a code owner December 23, 2021 19:44
@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team December 23, 2021 19:44
@iwiznia iwiznia changed the title Update guidelines on bugs not happening in production [HOLD] Update guidelines on bugs not happening in production Dec 23, 2021
@mallenexpensify

mallenexpensify commented Dec 23, 2021

Copy link
Copy Markdown
Contributor

@iwiznia . Line 49

and add the DeployBlockerCash label.

I don't think contributors are able to add labels in issues, so we likely want to update this, maybe to "leave a comment in the issue - "This might be a deploy blocker"" (or.. similar)

@iwiznia iwiznia changed the title [HOLD] Update guidelines on bugs not happening in production Update guidelines on bugs not happening in production Dec 27, 2021
@iwiznia

iwiznia commented Dec 30, 2021

Copy link
Copy Markdown
Contributor Author

Bump @danieldoglas

danieldoglas
danieldoglas approved these changes Dec 30, 2021
View reviewed changes

@danieldoglas danieldoglas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieldoglas danieldoglas merged commit 3c4558d into main Dec 30, 2021
@danieldoglas danieldoglas deleted the iwiznia-patch-1-1 branch December 30, 2021 19:54
@OSBotify

OSBotify commented Dec 30, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @danieldoglas in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify OSBotify mentioned this pull request Jan 4, 2022
Closed
45 tasks
@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@mallenexpensify

mallenexpensify commented Jan 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@iwiznia can you drop a comment in #expensify-open-source that includes details on this update and also include this update too? #6968 (comment)
Also.. this one so we can keep them all together?!?
#6887

@iwiznia

iwiznia commented Jan 4, 2022

Copy link
Copy Markdown
Contributor Author

I think it is not needed, GH shows to every contributor that the file was updated and tells you to check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieldoglas danieldoglas danieldoglas approved these changes

Assignees

@iwiznia iwiznia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iwiznia @mallenexpensify @OSBotify @danieldoglas