Make the current password field also submittable via Enter#6904
Merged
Conversation
Contributor
Author
|
Sorry @nickmurray47, this should have been draft PR at this point. |
mountiny
changed the title
Contributor
Author
|
@nickmurray47 This is ready for a review. It is a simple change and it is same as on the other password field in the form: https://github.com/Expensify/App/pull/6904/files#diff-b4474bebdf5744f78c9eded74e6bd3e4d2723040f750e573f4ef4bddfe00481bL189. I have tested it the other day, but unfortunately I did not make screenshots or video, but I believe this is such a simple change it is not required. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by @nickmurray47 in version: 1.1.24-19 🚀
|
45 tasks
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
A very small UI change which makes the
Current passwordfield actionable viaEnter.On the form to change password, this change would enable user to submit the form using
Enterkey also when theCurrent passwordfield would be focused. This is for scenario, when user enters both, current and new password, but realizes they entered the current password wrong, then they can submit the form while focusing the current password too.If the New password is not filled in, validation does not pass.
Fixed Issues
$ #6823
Tests
Change password pageQA Steps
Change password pageTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android