Skip to content

[No QA] Fix api usage inside AddEncryptedAuthToken migration#6915

Merged
marcaaron merged 3 commits into
Expensify:mainfrom
kidroca:kidroca/fix-encrypted-token-migration
Dec 30, 2021
Merged

[No QA] Fix api usage inside AddEncryptedAuthToken migration#6915
marcaaron merged 3 commits into
Expensify:mainfrom
kidroca:kidroca/fix-encrypted-token-migration

Conversation

@kidroca

@kidroca kidroca commented Dec 28, 2021

Copy link
Copy Markdown
Contributor

@marcaaron

Details

Fixes a problem related to migrating usages to import *
Looks like it was only applied partially here

Fixed Issues

$ N/A

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

image

@kidroca kidroca requested a review from a team as a code owner December 28, 2021 21:18
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team December 28, 2021 21:19
ctkochan22
ctkochan22 previously approved these changes Dec 28, 2021

@ctkochan22 ctkochan22 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change. @marcaaron let you merge

@marcaaron marcaaron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was on my list of things to fix, but never found the time to do it. Guessing not many were affected, but it was a careless mistake.

Comment thread src/libs/migrations/AddEncryptedAuthToken.js Outdated
@marcaaron marcaaron merged commit 74738c3 into Expensify:main Dec 30, 2021
@marcaaron

Copy link
Copy Markdown
Contributor

Looks great, thanks again!

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants