Add autoCapitalize prop to avoid first letter duplication on android#6916
Conversation
mountiny
left a comment
There was a problem hiding this comment.
@parasharrajat Now I am not sure how our linter is set up, but will it not throw error in case we do not define the the props? If that is not a problem, I agree with removing the props.
|
Yeah, @mountiny. It won't throw an error. |
Thanks, @parasharrajat! You were right, I didn't need to specify the props, I tested it and it works fine :) |
parasharrajat
left a comment
There was a problem hiding this comment.
Oops. I missed that. Could you please sign all the commits and we should be able to see your username for the signed GPG key.
Oops, I forgot about that. Would you recommend just doing a fresh new branch/PR? or try to amend the commits to add the signature? |
|
You can just force push and rebase the commits. That should be less time-consuming. |
Add autoCapitalize value none for WorkspaceNewRoomPage
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
eca8bb0 to
a79ad5b
Compare
Done! Thanks @parasharrajat |
mountiny
left a comment
There was a problem hiding this comment.
Thank you both for such a great cooperation! Thank you @CamilaRivera for this fix 🙌
Merging ![]()
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀
|
Details
Add
autoCapitalizeprop forTextInputWithPrefixandTextInputWithLabel(drill)Pass
autoCapitalize="none"prop toTextInputWithLabelin WorkspaceNewRoomPageFixed Issues
$ #6725
Tests | QA Steps
Expected result: You should not get the first letter duplicated
Tested On
Screenshots
Web
Screen.Recording.2021-12-28.at.8.39.09.PM.mov
Mobile Web
Desktop
iOS
Screen.Recording.2021-12-28.at.8.37.55.PM.mov
Android
XRecorder_Edited_28122021_122837.mp4