Skip to content

[No QA] Investigate workflow job failing on main: test / test (job 2) #69166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 3 commits into from
Aug 26, 2025
Merged

[No QA] Investigate workflow job failing on main: test / test (job 2) #69166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba24193
fix: pagination flaky test
lorretheboy Aug 25, 2025
1b3e12d
fix: pagination flaky test
lorretheboy Aug 25, 2025
51b4572
fix: pagination flaky test
lorretheboy Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/ui/PaginationTest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import PusherHelper from '../utils/PusherHelper';
import * as TestHelper from '../utils/TestHelper';
import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
import waitForBatchedUpdatesWithAct from '../utils/waitForBatchedUpdatesWithAct';
import waitForNetworkPromises from '../utils/waitForNetworkPromises';

// We need a large timeout here as we are lazy loading React Navigation screens and this test is running against the entire mounted App
jest.setTimeout(60000);
Expand Down Expand Up @@ -319,7 +320,7 @@ describe('Pagination', () => {
TestHelper.expectAPICommandToHaveBeenCalledWith('GetOlderActions', 0, {reportID: REPORT_ID, reportActionID: '4'});
TestHelper.expectAPICommandToHaveBeenCalled('GetNewerActions', 0);

await waitForBatchedUpdatesWithAct();
await waitForNetworkPromises();

@mountiny mountiny Aug 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here to explain why this is needed in some future prs

@lorretheboy lorretheboy Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean by adding a code-comment or can comment directly here? @mountiny

@shubham1206agra shubham1206agra Aug 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorretheboy Comment here

@lorretheboy lorretheboy Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here

@lorretheboy lorretheboy Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use waitForNetworkPromises instead of waitForBatchedUpdatesWithAct to prevent this from being flaky test. This is because the test is not waiting for the pagination middleware to fully process the GetOlderActions response and update the component tree. The waitForBatchedUpdatesWithAct() call is not sufficient because it doesn't wait for the specific pagination processing to complete


// We now have 18 messages. 15 (MIN_INITIAL_REPORT_ACTION_COUNT) from the initial OpenReport and 3 from GetOlderActions.
// GetOlderActions only returns 3 actions since it reaches id '1', which is the created action.
Expand Down
Loading