Invoice-After refreshing the app and starting invoice flow again previous amount is shown by thelullabyy · Pull Request #69255 · Expensify/App

thelullabyy · 2025-08-26T13:47:28Z

Explanation of Change

Fixed Issues

$#68416
PROPOSAL:#68416 (comment)

Tests

Create a new gmail account
Create a workspace and enable Invoices feature
Tap FAB - Send invoice
Enter an amount, tap Next
Enter a recipient email
Tap app back button 3 times (until you are on the LHN)
Refresh the app on Web or reopen it on Native mobile.
Repeat step 3
Verify the amount of previous invoice is not displayed, and it reset to 0

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a new gmail account
Create a workspace and enable Invoices feature
Tap FAB - Send invoice
Enter an amount, tap Next
Enter a recipient email
Tap app back button 3 times (until you are on the LHN)
Refresh the app on Web or reopen it on Native mobile.
Repeat step 3
Verify the amount of previous invoice is not displayed, and it reset to 0

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android_chorme.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_sfr.mov

MacOS: Chrome / Safari

chorme.mov

MacOS: Desktop

desktop.mov

…s shown

melvin-bot · 2025-08-26T14:01:27Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2025-08-28T17:45:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

a.mp4

Android: mWeb Chrome

aw.mp4

iOS: HybridApp

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

d.mp4

ahmedGaber93 · 2025-08-28T17:53:42Z

@thelullabyy Thanks for the PR, small change on test steps.

Refresh the app

Refresh the app on Web or reopen it on Native mobile.

Verify the amount is displayed for the newly started "Send invoice" flow

Is not displayed, and it reset to 0

ahmedGaber93

LGTM!

stitesExpensify

Code looks good functionally, one request for a variable name change

thelullabyy · 2025-09-08T07:28:51Z

@stitesExpensify Updated, please help to check

OSBotify · 2025-09-09T03:27:22Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.2.3-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MonilBhavsar · 2025-09-09T07:30:09Z

Looks like this PR caused #70159
If anyone can please take a look, or we can revert

ahmedGaber93 · 2025-09-09T07:59:13Z

@MonilBhavsar Please don't revert, I am trying to revert it locally to confirm.

ahmedGaber93 · 2025-09-09T08:24:14Z

@MonilBhavsar It is not related, I reverted it locally manual (GitHub couldn’t revert this PR automatically), and the issue still reproduced.

20250909112450041.mp4

mountiny · 2025-09-09T12:48:01Z

@ahmedGaber93 also this seems related #69634 (comment)

ahmedGaber93 · 2025-09-09T14:02:51Z

@mountiny @martasudol I'm away from the keyboard now, I will test it when back today. But from the first look, it looks not related and out of our PR context.

…previous-amount-is-shown" This reverts commit d98cf61, reversing changes made to c4b9ac2.

OSBotify · 2025-09-09T18:19:08Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.2.5-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

ahmedGaber93 · 2025-09-09T20:18:58Z

@martasudol I revert our PR locally and test this on it and also on staging.

My testing is scanning 2 times with .gpeg and 2 times with .heic files.

In staging, all cases are success (our PR is now on staging, the above revert reference is for test branch only).

video

20250909231501259.mp4

without our PR, the both .gpeg and .heic success in the first time and failed in the second time and open the upload page again.

video 1

20250909230357639.mp4

video 2

20250909230313120.mp4

OSBotify · 2025-09-09T21:21:06Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.2.8-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-10T22:59:00Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.8-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Refreshing app and starting invoice flow again previous amount i…

d826722

…s shown

melvin-bot Bot assigned thelullabyy Aug 26, 2025

thelullabyy marked this pull request as ready for review August 26, 2025 14:01

thelullabyy requested a review from a team as a code owner August 26, 2025 14:01

melvin-bot Bot requested review from ahmedGaber93 and removed request for a team August 26, 2025 14:01

ahmedGaber93 reviewed Aug 28, 2025

View reviewed changes

Comment thread src/libs/actions/Transaction.ts Outdated

ahmedGaber93 approved these changes Sep 4, 2025

View reviewed changes

melvin-bot Bot requested a review from stitesExpensify September 4, 2025 03:14

stitesExpensify requested changes Sep 5, 2025

View reviewed changes

Comment thread src/libs/actions/IOU.ts Outdated

thelullabyy added 2 commits September 8, 2025 14:15

Merge branch 'main' into fix/68416-invoice-previous-amount-is-shown

e3157b0

refactor code

9e450ff

stitesExpensify approved these changes Sep 8, 2025

View reviewed changes

stitesExpensify merged commit d98cf61 into Expensify:main Sep 8, 2025
19 checks passed

OSBotify mentioned this pull request Sep 9, 2025

Deploy Checklist: New Expensify 2025-09-09 #70157

Closed

83 tasks

jponikarchuk mentioned this pull request Sep 9, 2025

Expense - RHP reopens amount input page instead of confirm page when submiting expense #70159

Closed

8 tasks

MonilBhavsar added a commit that referenced this pull request Sep 9, 2025

Revert "Merge pull request #69255 from thelullabyy/fix/68416-invoice-…

ebceb43

…previous-amount-is-shown" This reverts commit d98cf61, reversing changes made to c4b9ac2.

melvin-bot Bot mentioned this pull request Sep 10, 2025

[Due for payment 2025-09-17] [$250] Invoice-After refreshing the app and starting invoice flow again previous amount is shown #68416

Closed

8 tasks

Conversation

thelullabyy commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 26, 2025

Uh oh!

ahmedGaber93 commented Aug 28, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thelullabyy commented Sep 8, 2025

Uh oh!

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

MonilBhavsar commented Sep 9, 2025

Uh oh!

ahmedGaber93 commented Sep 9, 2025

Uh oh!

ahmedGaber93 commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Sep 9, 2025

Uh oh!

ahmedGaber93 commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

ahmedGaber93 commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

thelullabyy commented Aug 26, 2025 •

edited

Loading

ahmedGaber93 commented Aug 28, 2025 •

edited

Loading

ahmedGaber93 commented Sep 9, 2025 •

edited

Loading