Skip to content

[No QA] fix: Added translate key for street name based on the form#6930

Merged
aldo-expensify merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/street-placeholder
Dec 29, 2021
Merged

[No QA] fix: Added translate key for street name based on the form#6930
aldo-expensify merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/street-placeholder

Conversation

@mananjadhav

@mananjadhav mananjadhav commented Dec 29, 2021

Copy link
Copy Markdown
Collaborator

Details

Fixed Issues

$ #6928

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@mananjadhav mananjadhav requested a review from a team as a code owner December 29, 2021 16:31
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team December 29, 2021 16:32
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@aldo-expensify aldo-expensify self-requested a review December 29, 2021 16:55

@aldo-expensify aldo-expensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works well, I'll merge after E2E tests.

@aldo-expensify aldo-expensify merged commit 26c0c2e into Expensify:main Dec 29, 2021
OSBotify pushed a commit that referenced this pull request Dec 29, 2021
[No QA] fix: Added translate key for street name based on the form

(cherry picked from commit 26c0c2e)
@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @aldo-expensify in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants