Skip to content

[CP Staging] Hover Preview - follow ups #69337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 6 commits into from
Sep 1, 2025
Merged

[CP Staging] Hover Preview - follow ups #69337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41382b2
add isAuthTokenRequired for distanceEReceipts
borys3kk Aug 27, 2025
a6a6a71
fix eReceipt preview misaligned
borys3kk Aug 27, 2025
19c4e46
update name for future reference
borys3kk Aug 27, 2025
734a4e9
add display name
borys3kk Aug 27, 2025
8c5a33f
update main
borys3kk Aug 28, 2025
2a74866
fix jsdoc
borys3kk Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/DistanceEReceipt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ function DistanceEReceipt({transaction, hoverPreview = false}: DistanceEReceiptP
source={thumbnailSource}
shouldUseThumbnailImage
shouldUseInitialObjectPosition
isAuthTokenRequired
/>
)}
</View>
Expand Down
8 changes: 7 additions & 1 deletion src/components/EReceiptWithSizeCalculation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,14 @@ import EReceipt from './EReceipt';
import type {TransactionListItemType} from './SelectionList/types';

type EReceiptWithSizeCalculationProps = {
/* TransactionID of the transaction this EReceipt corresponds to */
transactionID: string | undefined;

/** The transaction data in search */
transactionItem?: TransactionListItemType | Transaction;

/** Whether the eReceipt should preserve aspect ratio */
shouldUseAspectRatio?: boolean;
};

const eReceiptAspectRatio = variables.eReceiptBGHWidth / variables.eReceiptBGHeight;
Expand All @@ -33,7 +38,8 @@ function EReceiptWithSizeCalculation(props: EReceiptWithSizeCalculationProps) {
style={[
styles.w100,
styles.h100,
{transform: `scale(${scaleFactor}) ${styles.translateZ0.transform as string}`, transformOrigin: 'top left', aspectRatio: eReceiptAspectRatio},
{transform: `scale(${scaleFactor}) ${styles.translateZ0.transform as string}`, transformOrigin: 'top left'},
props.shouldUseAspectRatio && {aspectRatio: eReceiptAspectRatio},
Comment thread
borys3kk marked this conversation as resolved.
]}
>
<EReceipt
Expand Down
2 changes: 2 additions & 0 deletions src/components/TransactionItemRow/ReceiptPreview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ function ReceiptPreview({source, hovered, isEReceipt = false, transactionItem}:
<EReceiptWithSizeCalculation
transactionID={transactionItem.transactionID}
transactionItem={transactionItem}
shouldUseAspectRatio
/>
)}
</View>
Expand All @@ -165,4 +166,5 @@ function ReceiptPreview({source, hovered, isEReceipt = false, transactionItem}:
);
}

ReceiptPreview.displayName = 'HoverReceiptPreview';
export default ReceiptPreview;
Loading